Re: [PATCH 08/36] perf build: Add builtin objects building

[David Ahern <dsahern@gmail.com>]

On 1/20/15 9:39 AM, Jiri Olsa wrote:
> Move the rest of builtin objects (bench and test are
> already in) building under build framework.
>
> Signed-off-by: Jiri Olsa <jolsa@kernel.org>
> Cc: Alexis Berlemont <alexis.berlemont@gmail.com>
> Cc: Arnaldo Carvalho de Melo <acme@redhat.com>
> Cc: Borislav Petkov <bp@alien8.de>
> Cc: Corey Ashford <cjashfor@linux.vnet.ibm.com>
> Cc: David Ahern <dsahern@gmail.com>
> Cc: Frederic Weisbecker <fweisbec@gmail.com>
> Cc: Ingo Molnar <mingo@kernel.org>
> Cc: Namhyung Kim <namhyung@kernel.org>
> Cc: Paul Mackerras <paulus@samba.org>
> Cc: Peter Zijlstra <peterz@infradead.org>
> Cc: Stephane Eranian <eranian@google.com>
> ---
>   tools/perf/Build           | 29 +++++++++++++++++++++++++++++
>   tools/perf/Makefile.perf   | 35 -----------------------------------
>   tools/perf/config/Makefile |  4 ++++
>   3 files changed, 33 insertions(+), 35 deletions(-)

This one fails to build:

$ git --no-pager log --oneline -1
cd2a9b144028 perf build: Add builtin objects building

$ make O=/tmp/junk
...
builtin-help.c:10:25: fatal error: common-cmds.h: No such file or directory
compilation terminated.
   CC       /tmp/junk/fs/fs.o
   CC       /tmp/junk/builtin-script.o
   CC       /tmp/junk/builtin-kmem.o
   CC       /tmp/junk/perf-read-vdso32
   CC       /tmp/junk/ui/gtk/browser.o
   CC       /tmp/junk/fd/array.o
   CC       /tmp/junk/ui/gtk/hists.o
   CC       /tmp/junk/builtin-lock.o
make[2]: *** [/tmp/junk/builtin-help.o] Error 1
make[2]: *** Waiting for unfinished jobs....

Probably due to this change:

> @@ -591,18 +568,6 @@ $(GTK_OBJS): $(OUTPUT)%.o: %.c $(LIB_H)
>   $(OUTPUT)libperf-gtk.so: $(GTK_OBJS) $(PERFLIBS)
>   	$(QUIET_LINK)$(CC) -o $@ -shared $(LDFLAGS) $(filter %.o,$^) $(GTK_LIBS)
>
> -$(OUTPUT)builtin-help.o: builtin-help.c $(OUTPUT)common-cmds.h $(OUTPUT)PERF-CFLAGS
> -	$(QUIET_CC)$(CC) -o $@ -c $(CFLAGS) \
> -		'-DPERF_HTML_PATH="$(htmldir_SQ)"' \
> -		'-DPERF_MAN_PATH="$(mandir_SQ)"' \
> -		'-DPERF_INFO_PATH="$(infodir_SQ)"' $<
> -
> -$(OUTPUT)builtin-timechart.o: builtin-timechart.c $(OUTPUT)common-cmds.h $(OUTPUT)PERF-CFLAGS
> -	$(QUIET_CC)$(CC) -o $@ -c $(CFLAGS) \
> -		'-DPERF_HTML_PATH="$(htmldir_SQ)"' \
> -		'-DPERF_MAN_PATH="$(mandir_SQ)"' \
> -		'-DPERF_INFO_PATH="$(infodir_SQ)"' $<
> -

David