LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: "Bryan O'Donoghue" <pure.logic@nexus-software.ie>
To: Thomas Gleixner <tglx@linutronix.de>
Cc: mingo@redhat.com, hpa@zytor.com, x86@kernel.org,
	dvhart@infradead.org, andy.shevchenko@gmail.com,
	boon.leong.ong@intel.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 1/1] x86: Add Isolated Memory Regions for Quark X1000
Date: Thu, 22 Jan 2015 11:38:35 +0000	[thread overview]
Message-ID: <54C0E13B.2070400@nexus-software.ie> (raw)
In-Reply-To: <alpine.DEB.2.11.1501221220530.5526@nanos>

On 22/01/15 11:24, Thomas Gleixner wrote:
> On Wed, 21 Jan 2015, Bryan O'Donoghue wrote:
>>   arch/x86/Kconfig           |  25 ++
>>   arch/x86/Kconfig.debug     |  13 +
>>   arch/x86/include/asm/imr.h |  60 ++++
>>   arch/x86/kernel/Makefile   |   1 +
>>   arch/x86/kernel/imr.c      | 681 +++++++++++++++++++++++++++++++++++++++++++++
>
> Can we please stop to dump random stuff into x86/kernel?
>
> x86/platform ... would be a proper place for this.
>
> Thanks,
>
> 	tglx
>

Hi Thomas.

The IMR registers live in the north cluster of the SoC which is why I 
thought arch/x86/kernel would be the best place for this code.

That said, there's no technical reason we couldn't move this code to

drivers/platform/x86/intel_qrk_imr.c

Darren - would that be acceptable to you ?



  reply	other threads:[~2015-01-22 11:38 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-01-21 18:46 [PATCH v2 0/1] x86: Add IMR support to Quark/Galileo Bryan O'Donoghue
2015-01-21 18:46 ` [PATCH v2 1/1] x86: Add Isolated Memory Regions for Quark X1000 Bryan O'Donoghue
2015-01-21 20:57   ` Andy Shevchenko
2015-01-22  1:27     ` Bryan O'Donoghue
2015-01-22  8:59       ` Andy Shevchenko
2015-01-22  9:43         ` Bryan O'Donoghue
2015-01-22 11:24   ` Thomas Gleixner
2015-01-22 11:38     ` Bryan O'Donoghue [this message]
2015-01-22 15:02       ` Bryan O'Donoghue
2015-01-22 15:15         ` Bryan O'Donoghue
2015-01-22 16:28           ` Darren Hart
2015-01-22 19:50           ` Thomas Gleixner
2015-01-24  1:48   ` Ong, Boon Leong
2015-01-24 11:02     ` Andy Shevchenko
2015-01-24 21:56       ` Bryan O'Donoghue
2015-01-24 21:58         ` Bryan O'Donoghue
2015-01-24 19:52     ` Bryan O'Donoghue

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=54C0E13B.2070400@nexus-software.ie \
    --to=pure.logic@nexus-software.ie \
    --cc=andy.shevchenko@gmail.com \
    --cc=boon.leong.ong@intel.com \
    --cc=dvhart@infradead.org \
    --cc=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=tglx@linutronix.de \
    --cc=x86@kernel.org \
    --subject='Re: [PATCH v2 1/1] x86: Add Isolated Memory Regions for Quark X1000' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).