LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
* [PATCH 1/3] hyperv: netvsc.c: fixup-of-wait_for_completion_timeout-return-type
@ 2015-01-25 11:03 Nicholas Mc Guire
  2015-01-25 11:37 ` Sergei Shtylyov
  0 siblings, 1 reply; 2+ messages in thread
From: Nicholas Mc Guire @ 2015-01-25 11:03 UTC (permalink / raw)
  To: K. Y. Srinivasan
  Cc: Haiyang Zhang, devel, netdev, linux-kernel, Nicholas Mc Guire

Signed-off-by: Nicholas Mc Guire <der.herr@hofr.at>
---

The return type of wait_for_completion_timeout is unsigned long not
int. This patch fixes up the declarations only.

Patch was compile tested only for x86_64_defconfig + CONFIG_X86_VSMP=y
CONFIG_HYPERV=m, CONFIG_HYPERV_NET=m

Patch is against 3.19.0-rc5 -next-20150123

 drivers/net/hyperv/netvsc.c |    5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/drivers/net/hyperv/netvsc.c b/drivers/net/hyperv/netvsc.c
index 9f49c01..d2af032 100644
--- a/drivers/net/hyperv/netvsc.c
+++ b/drivers/net/hyperv/netvsc.c
@@ -217,7 +217,7 @@ static int netvsc_destroy_buf(struct netvsc_device *net_device)
 static int netvsc_init_buf(struct hv_device *device)
 {
 	int ret = 0;
-	int t;
+	unsigned long t;
 	struct netvsc_device *net_device;
 	struct nvsp_message *init_packet;
 	struct net_device *ndev;
@@ -409,7 +409,8 @@ static int negotiate_nvsp_ver(struct hv_device *device,
 			      struct nvsp_message *init_packet,
 			      u32 nvsp_ver)
 {
-	int ret, t;
+	int ret;
+	unsigned long t;
 
 	memset(init_packet, 0, sizeof(struct nvsp_message));
 	init_packet->hdr.msg_type = NVSP_MSG_TYPE_INIT;
-- 
1.7.10.4


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH 1/3] hyperv: netvsc.c: fixup-of-wait_for_completion_timeout-return-type
  2015-01-25 11:03 [PATCH 1/3] hyperv: netvsc.c: fixup-of-wait_for_completion_timeout-return-type Nicholas Mc Guire
@ 2015-01-25 11:37 ` Sergei Shtylyov
  0 siblings, 0 replies; 2+ messages in thread
From: Sergei Shtylyov @ 2015-01-25 11:37 UTC (permalink / raw)
  To: Nicholas Mc Guire, K. Y. Srinivasan
  Cc: Haiyang Zhang, devel, netdev, linux-kernel

Hello.

On 1/25/2015 2:03 PM, Nicholas Mc Guire wrote:

    You probably want to replace hyphens with spaces in the subject of this 
and other patches.
    And you're not fixing the return type of wait_for_completion_timeout(), 
you're fixing the variables to match this type.

> Signed-off-by: Nicholas Mc Guire <der.herr@hofr.at>

WBR, Sergei


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2015-01-25 11:37 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-01-25 11:03 [PATCH 1/3] hyperv: netvsc.c: fixup-of-wait_for_completion_timeout-return-type Nicholas Mc Guire
2015-01-25 11:37 ` Sergei Shtylyov

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).