LKML Archive on
help / color / mirror / Atom feed
From: Peter Hurley <>
To: Johannes Thumshirn <>,
	Greg Kroah-Hartman <>
Cc: Jiri Slaby <>,,
Subject: Re: [PATCH v5] tty: serial: men_z135_uart: Fix driver for changes in hardware
Date: Sun, 25 Jan 2015 16:17:27 -0500	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <>

On 01/19/2015 01:44 AM, Johannes Thumshirn wrote:
> 16z135 IP Core has changed so the driver needs to be updated to respect
> these changes. The following changes have been made:
> * Don't invert the 16z135 modem status register when reading.
> * Add module parameter to configure the (baud rate dependent) RX timeout.
>   Character timeout in seconds = (timeout_reg * baud_reg * 4)/freq_reg.
> * Enable the handling of UART core's automatic flow control feature.
>   When AFE is active disable generation of modem status IRQs.
> * Rework the handling of IRQs to be conform with newer FPGA versions and
>   take precautions not to miss an interrupt because of the destructive read
>   of the IIR register.
> * Correct men_z135_handle_modem_status(), MSR is stat_reg[15:8] not
>   stat_reg[7:0]
> * Correct calling of uart_handle_{dcd,cts}_change()
> * Reset CLOCAL when CRTSCTS is set

Reviewed-by: Peter Hurley <>

      reply	other threads:[~2015-01-25 21:17 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-01-19  6:44 Johannes Thumshirn
2015-01-25 21:17 ` Peter Hurley [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \ \ \
    --subject='Re: [PATCH v5] tty: serial: men_z135_uart: Fix driver for changes in hardware' \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).