LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Jaehoon Chung <jh80.chung@samsung.com>
To: Javier Martinez Canillas <javier@dowhile0.org>,
	Sjoerd Simons <sjoerd.simons@collabora.co.uk>
Cc: "linux-samsung-soc@vger.kernel.org" 
	<linux-samsung-soc@vger.kernel.org>,
	Kukjin Kim <kgene@kernel.org>,
	Linux Kernel <linux-kernel@vger.kernel.org>,
	"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>
Subject: Re: [PATCH] ARM: dts: Add sd0_rst pinctrl node to exynos5420
Date: Mon, 26 Jan 2015 10:47:24 +0900	[thread overview]
Message-ID: <54C59CAC.8020509@samsung.com> (raw)
In-Reply-To: <CABxcv=kARp8xLYCqf8dfdKd9ehs1u=qTEjkn1iujhN77ZjPdTA@mail.gmail.com>

Hi,

On 01/24/2015 12:59 AM, Javier Martinez Canillas wrote:
> Hello Sjoerd,
> 
> On Fri, Jan 23, 2015 at 4:47 PM, Sjoerd Simons
> <sjoerd.simons@collabora.co.uk> wrote:
>>>
>>> If this pin is used by the Odroid XU3 board, shouldn't be defined in
>>> the exynos5422-odroidxu3.dts instead?
>>
>> It's not just used by the XU3 though, it's also hooked up on the peach
>> pi chromebook for example and i would expect it to be hooked up on most
>> board with an eMMC
>>
>> This change is consistent with most of the special purpose GPIO pins
>> defined in that file, so i don't see the problem with including it in
>> that pinctrl file
> 
> In that case I completely agree that it should be defined in the .dtsi
> but that is not what the commit message said though :-)

I will resend the patch with obvious commit message.
Thanks for review.

Best Regards,
Jaehoon Chung

> 
> Best regards,
> Javier
> 


  reply	other threads:[~2015-01-26  1:47 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-01-23 14:23 Jaehoon Chung
2015-01-23 14:36 ` Javier Martinez Canillas
2015-01-23 15:47   ` Sjoerd Simons
2015-01-23 15:59     ` Javier Martinez Canillas
2015-01-26  1:47       ` Jaehoon Chung [this message]
2015-01-23 15:50 ` Sjoerd Simons

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=54C59CAC.8020509@samsung.com \
    --to=jh80.chung@samsung.com \
    --cc=devicetree@vger.kernel.org \
    --cc=javier@dowhile0.org \
    --cc=kgene@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-samsung-soc@vger.kernel.org \
    --cc=sjoerd.simons@collabora.co.uk \
    --subject='Re: [PATCH] ARM: dts: Add sd0_rst pinctrl node to exynos5420' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).