LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
* [PATCH] ARM: dts: Add sd0_rst pinctrl node to exynos5420
@ 2015-01-23 14:23 Jaehoon Chung
  2015-01-23 14:36 ` Javier Martinez Canillas
  2015-01-23 15:50 ` Sjoerd Simons
  0 siblings, 2 replies; 6+ messages in thread
From: Jaehoon Chung @ 2015-01-23 14:23 UTC (permalink / raw)
  To: linux-samsung-soc; +Cc: kgene, linux-kernel, devicetree, Jaehoon Chung

Add sd0_rst node to exynos5420-pinctrl.dtsi.
(It's used on odroid-xu3 board)

Signed-off-by: Jaehoon Chung <jh80.chung@samsung.com>
---
 arch/arm/boot/dts/exynos5420-pinctrl.dtsi |    5 +++++
 1 file changed, 5 insertions(+)

diff --git a/arch/arm/boot/dts/exynos5420-pinctrl.dtsi b/arch/arm/boot/dts/exynos5420-pinctrl.dtsi
index ba686e4..315cad7 100644
--- a/arch/arm/boot/dts/exynos5420-pinctrl.dtsi
+++ b/arch/arm/boot/dts/exynos5420-pinctrl.dtsi
@@ -194,6 +194,11 @@
 			samsung,pin-drv = <3>;
 		};
 
+		sd0_rst: sd0-rst {
+			samsung,pins = "gpd1-0";
+			samsung,pin-function = <1>;
+		};
+
 		sd1_clk: sd1-clk {
 			samsung,pins = "gpc1-0";
 			samsung,pin-function = <2>;
-- 
1.7.9.5


^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH] ARM: dts: Add sd0_rst pinctrl node to exynos5420
  2015-01-23 14:23 [PATCH] ARM: dts: Add sd0_rst pinctrl node to exynos5420 Jaehoon Chung
@ 2015-01-23 14:36 ` Javier Martinez Canillas
  2015-01-23 15:47   ` Sjoerd Simons
  2015-01-23 15:50 ` Sjoerd Simons
  1 sibling, 1 reply; 6+ messages in thread
From: Javier Martinez Canillas @ 2015-01-23 14:36 UTC (permalink / raw)
  To: Jaehoon Chung; +Cc: linux-samsung-soc, Kukjin Kim, Linux Kernel, devicetree

Hello Jaehoon,

On Fri, Jan 23, 2015 at 3:23 PM, Jaehoon Chung <jh80.chung@samsung.com> wrote:
> Add sd0_rst node to exynos5420-pinctrl.dtsi.
> (It's used on odroid-xu3 board)
>

It would be good to mention which device needs this pinctrl line.

> Signed-off-by: Jaehoon Chung <jh80.chung@samsung.com>
> ---
>  arch/arm/boot/dts/exynos5420-pinctrl.dtsi |    5 +++++

If this pin is used by the Odroid XU3 board, shouldn't be defined in
the exynos5422-odroidxu3.dts instead?

Best regards,
Javier

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH] ARM: dts: Add sd0_rst pinctrl node to exynos5420
  2015-01-23 14:36 ` Javier Martinez Canillas
@ 2015-01-23 15:47   ` Sjoerd Simons
  2015-01-23 15:59     ` Javier Martinez Canillas
  0 siblings, 1 reply; 6+ messages in thread
From: Sjoerd Simons @ 2015-01-23 15:47 UTC (permalink / raw)
  To: Javier Martinez Canillas
  Cc: Jaehoon Chung, linux-samsung-soc, Kukjin Kim, Linux Kernel, devicetree

[-- Attachment #1: Type: text/plain, Size: 984 bytes --]

On Fri, 2015-01-23 at 15:36 +0100, Javier Martinez Canillas wrote:
> Hello Jaehoon,
> 
> On Fri, Jan 23, 2015 at 3:23 PM, Jaehoon Chung <jh80.chung@samsung.com> wrote:
> > Add sd0_rst node to exynos5420-pinctrl.dtsi.
> > (It's used on odroid-xu3 board)
> >
> 
> It would be good to mention which device needs this pinctrl line.
> 
> > Signed-off-by: Jaehoon Chung <jh80.chung@samsung.com>
> > ---
> >  arch/arm/boot/dts/exynos5420-pinctrl.dtsi |    5 +++++
> 
> If this pin is used by the Odroid XU3 board, shouldn't be defined in
> the exynos5422-odroidxu3.dts instead?

It's not just used by the XU3 though, it's also hooked up on the peach
pi chromebook for example and i would expect it to be hooked up on most
board with an eMMC

This change is consistent with most of the special purpose GPIO pins
defined in that file, so i don't see the problem with including it in
that pinctrl file
-- 
Sjoerd Simons <sjoerd.simons@collabora.co.uk>
Collabora Ltd.

[-- Attachment #2: smime.p7s --]
[-- Type: application/x-pkcs7-signature, Size: 6170 bytes --]

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH] ARM: dts: Add sd0_rst pinctrl node to exynos5420
  2015-01-23 14:23 [PATCH] ARM: dts: Add sd0_rst pinctrl node to exynos5420 Jaehoon Chung
  2015-01-23 14:36 ` Javier Martinez Canillas
@ 2015-01-23 15:50 ` Sjoerd Simons
  1 sibling, 0 replies; 6+ messages in thread
From: Sjoerd Simons @ 2015-01-23 15:50 UTC (permalink / raw)
  To: Jaehoon Chung; +Cc: linux-samsung-soc, kgene, linux-kernel, devicetree

[-- Attachment #1: Type: text/plain, Size: 853 bytes --]

On Fri, 2015-01-23 at 23:23 +0900, Jaehoon Chung wrote:
> Add sd0_rst node to exynos5420-pinctrl.dtsi.
> (It's used on odroid-xu3 board)
> 
> Signed-off-by: Jaehoon Chung <jh80.chung@samsung.com>
> ---
>  arch/arm/boot/dts/exynos5420-pinctrl.dtsi |    5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/exynos5420-pinctrl.dtsi b/arch/arm/boot/dts/exynos5420-pinctrl.dtsi
> index ba686e4..315cad7 100644
> --- a/arch/arm/boot/dts/exynos5420-pinctrl.dtsi
> +++ b/arch/arm/boot/dts/exynos5420-pinctrl.dtsi
> @@ -194,6 +194,11 @@
>  			samsung,pin-drv = <3>;
>  		};
>  
> +		sd0_rst: sd0-rst {
> +			samsung,pins = "gpd1-0";
> +			samsung,pin-function = <1>;

I think this should be samsung,pin-function = <2>; for that
functionality.

-- 
Sjoerd Simons <sjoerd.simons@collabora.co.uk>
Collabora Ltd.

[-- Attachment #2: smime.p7s --]
[-- Type: application/x-pkcs7-signature, Size: 6170 bytes --]

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH] ARM: dts: Add sd0_rst pinctrl node to exynos5420
  2015-01-23 15:47   ` Sjoerd Simons
@ 2015-01-23 15:59     ` Javier Martinez Canillas
  2015-01-26  1:47       ` Jaehoon Chung
  0 siblings, 1 reply; 6+ messages in thread
From: Javier Martinez Canillas @ 2015-01-23 15:59 UTC (permalink / raw)
  To: Sjoerd Simons
  Cc: Jaehoon Chung, linux-samsung-soc, Kukjin Kim, Linux Kernel, devicetree

Hello Sjoerd,

On Fri, Jan 23, 2015 at 4:47 PM, Sjoerd Simons
<sjoerd.simons@collabora.co.uk> wrote:
>>
>> If this pin is used by the Odroid XU3 board, shouldn't be defined in
>> the exynos5422-odroidxu3.dts instead?
>
> It's not just used by the XU3 though, it's also hooked up on the peach
> pi chromebook for example and i would expect it to be hooked up on most
> board with an eMMC
>
> This change is consistent with most of the special purpose GPIO pins
> defined in that file, so i don't see the problem with including it in
> that pinctrl file

In that case I completely agree that it should be defined in the .dtsi
but that is not what the commit message said though :-)

Best regards,
Javier

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH] ARM: dts: Add sd0_rst pinctrl node to exynos5420
  2015-01-23 15:59     ` Javier Martinez Canillas
@ 2015-01-26  1:47       ` Jaehoon Chung
  0 siblings, 0 replies; 6+ messages in thread
From: Jaehoon Chung @ 2015-01-26  1:47 UTC (permalink / raw)
  To: Javier Martinez Canillas, Sjoerd Simons
  Cc: linux-samsung-soc, Kukjin Kim, Linux Kernel, devicetree

Hi,

On 01/24/2015 12:59 AM, Javier Martinez Canillas wrote:
> Hello Sjoerd,
> 
> On Fri, Jan 23, 2015 at 4:47 PM, Sjoerd Simons
> <sjoerd.simons@collabora.co.uk> wrote:
>>>
>>> If this pin is used by the Odroid XU3 board, shouldn't be defined in
>>> the exynos5422-odroidxu3.dts instead?
>>
>> It's not just used by the XU3 though, it's also hooked up on the peach
>> pi chromebook for example and i would expect it to be hooked up on most
>> board with an eMMC
>>
>> This change is consistent with most of the special purpose GPIO pins
>> defined in that file, so i don't see the problem with including it in
>> that pinctrl file
> 
> In that case I completely agree that it should be defined in the .dtsi
> but that is not what the commit message said though :-)

I will resend the patch with obvious commit message.
Thanks for review.

Best Regards,
Jaehoon Chung

> 
> Best regards,
> Javier
> 


^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2015-01-26  1:47 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-01-23 14:23 [PATCH] ARM: dts: Add sd0_rst pinctrl node to exynos5420 Jaehoon Chung
2015-01-23 14:36 ` Javier Martinez Canillas
2015-01-23 15:47   ` Sjoerd Simons
2015-01-23 15:59     ` Javier Martinez Canillas
2015-01-26  1:47       ` Jaehoon Chung
2015-01-23 15:50 ` Sjoerd Simons

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).