From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756195AbbAZK0w (ORCPT ); Mon, 26 Jan 2015 05:26:52 -0500 Received: from mail-wg0-f44.google.com ([74.125.82.44]:46547 "EHLO mail-wg0-f44.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752164AbbAZK0s (ORCPT ); Mon, 26 Jan 2015 05:26:48 -0500 Message-ID: <54C61665.1000300@linaro.org> Date: Mon, 26 Jan 2015 11:26:45 +0100 From: Daniel Lezcano User-Agent: Mozilla/5.0 (X11; Linux i686; rv:31.0) Gecko/20100101 Thunderbird/31.3.0 MIME-Version: 1.0 To: Baruch Siach CC: Thomas Gleixner , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v4 2/2] clocksource: driver for Conexant Digicolor SoC timer References: <54C60C4F.50507@linaro.org> <20150126101511.GC3148@tarshish> In-Reply-To: <20150126101511.GC3148@tarshish> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 01/26/2015 11:15 AM, Baruch Siach wrote: > Hi Daniel, [ ... ] >> >> What do you think ? > > OK. I'll give it a try. > > Thanks for your prompt response and thorough review. Maxime Ripard just sent a patchset (patch 4/5) with some changes suggested above :) http://www.spinics.net/lists/arm-kernel/msg394704.html As you may see, the enable/disable is passing the timer channel as parameter while I suggested to store it in the structure. It is up to you to choose what fits better for your future needs. -- Daniel -- Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog