LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Stathis Voukelatos <stathis.voukelatos@linn.co.uk>
To: Joe Perches <joe@perches.com>
Cc: <netdev@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
	<devicetree@vger.kernel.org>, <abrestic@chromium.org>
Subject: Re: [PATCH] net: Linn Ethernet Packet Sniffer driver
Date: Mon, 26 Jan 2015 11:11:07 +0000	[thread overview]
Message-ID: <54C620CB.3010500@linn.co.uk> (raw)
In-Reply-To: <1422135432.18650.2.camel@perches.com>


On 24/01/15 21:37, Joe Perches wrote:
> On Fri, 2015-01-23 at 10:07 +0000, Stathis Voukelatos wrote:
>> This patch adds support the Ethernet Packet Sniffer H/W module
>> developed by Linn Products Ltd and found in the IMG Pistachio SoC.
>> The module allows Ethernet packets to be parsed, matched against
>> a user-defined pattern and timestamped. It sits between a 100M
>> Ethernet MAC and PHY and is completely passive with respect to
>> Ethernet frames.
> []
>>   include/linux/pkt_sniffer.h                        |  89 +++++
> Why should this file be here?
> Why not in the drivers/net/pkt-sniffer directory?
>
Hi Joe,
Thank you for the feedback.
This header file is the public API for the driver.
Should it not live under the 'include' directory?
Several other drivers seem to follow that convention.

I will include your other suggestions in the next version
of the patch set.
Thank you,
Stathis

  reply	other threads:[~2015-01-26 11:11 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-01-23 10:07 Stathis Voukelatos
2015-01-23 10:21 ` Arnd Bergmann
2015-01-26 11:23   ` Stathis Voukelatos
2015-01-23 10:51 ` Mark Rutland
2015-01-26 10:16   ` Stathis Voukelatos
2015-01-27 10:53     ` Mark Rutland
2015-01-23 11:20 ` Daniel Borkmann
2015-01-26  9:49   ` Stathis Voukelatos
2015-01-26 10:10     ` Daniel Borkmann
2015-01-27 11:15       ` Stathis Voukelatos
2015-01-27 14:46         ` Daniel Borkmann
2015-01-27 17:22           ` Stathis Voukelatos
2015-01-23 18:12 ` James Hogan
2015-01-26 11:05   ` Stathis Voukelatos
2015-01-24 21:37 ` Joe Perches
2015-01-26 11:11   ` Stathis Voukelatos [this message]
2015-01-26 19:39     ` Joe Perches
2015-01-27  9:52       ` Stathis Voukelatos
2015-01-26 22:30 ` Florian Fainelli
2015-01-27 10:51   ` Stathis Voukelatos

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=54C620CB.3010500@linn.co.uk \
    --to=stathis.voukelatos@linn.co.uk \
    --cc=abrestic@chromium.org \
    --cc=devicetree@vger.kernel.org \
    --cc=joe@perches.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --subject='Re: [PATCH] net: Linn Ethernet Packet Sniffer driver' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).