LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Ian Abbott <abbotti@mev.co.uk>
To: Simon Guo <wei.guo.simon@gmail.com>,
	H Hartley Sweeten <hsweeten@visionengravers.com>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3.19.0-rc5 01/03] STAGING: Fix pcl818.c coding style issue: code indent should use tabs where possible
Date: Mon, 26 Jan 2015 11:31:47 +0000	[thread overview]
Message-ID: <54C625A3.4020001@mev.co.uk> (raw)
In-Reply-To: <20150125092816.GA4076@thunderCat>

On 25/01/15 09:28, Simon Guo wrote:
> Correct one coding style problem(detected by checkpatch.pl) in pcl818.c.
> - code indent should use tabs where possible
>
> Signed-off-by: Simon Guo <wei.guo.simon@gmail.com>
> ---
>   drivers/staging/comedi/drivers/pcl818.c | 26 +++++++++++++-------------
>   1 file changed, 13 insertions(+), 13 deletions(-)
>
> diff --git a/drivers/staging/comedi/drivers/pcl818.c b/drivers/staging/comedi/drivers/pcl818.c
> index ba2e137..72a700c 100644
> --- a/drivers/staging/comedi/drivers/pcl818.c
> +++ b/drivers/staging/comedi/drivers/pcl818.c
> @@ -45,11 +45,11 @@ A word or two about DMA. Driver support DMA operations at two ways:
>       [1] - IRQ	(0=disable, 2, 3, 4, 5, 6, 7)
>       [2] - DMA	(0=disable, 1, 3)
>       [3] - 0, 10=10MHz clock for 8254
> -              1= 1MHz clock for 8254
> +	      1= 1MHz clock for 8254
>       [4] - 0,  5=A/D input  -5V.. +5V
> -          1, 10=A/D input -10V..+10V
> +	  1, 10=A/D input -10V..+10V
>       [5] - 0,  5=D/A output 0-5V  (internal reference -5V)
> -          1, 10=D/A output 0-10V (internal reference -10V)
> +	  1, 10=D/A output 0-10V (internal reference -10V)
>   	  2    =D/A output unknown (external reference)
>
>      Options for PCL-818, PCL-818H:
> @@ -57,28 +57,28 @@ A word or two about DMA. Driver support DMA operations at two ways:
>       [1] - IRQ	(0=disable, 2, 3, 4, 5, 6, 7)
>       [2] - DMA	(0=disable, 1, 3)
>       [3] - 0, 10=10MHz clock for 8254
> -              1= 1MHz clock for 8254
> +	      1= 1MHz clock for 8254
>       [4] - 0,  5=D/A output 0-5V  (internal reference -5V)
> -          1, 10=D/A output 0-10V (internal reference -10V)
> +	  1, 10=D/A output 0-10V (internal reference -10V)
>   	  2    =D/A output unknown (external reference)
>
>      Options for PCL-818HD, PCL-818HG:
>       [0] - IO Base
>       [1] - IRQ	(0=disable, 2, 3, 4, 5, 6, 7)
>       [2] - DMA/FIFO  (-1=use FIFO, 0=disable both FIFO and DMA,
> -                      1=use DMA ch 1, 3=use DMA ch 3)
> +		      1=use DMA ch 1, 3=use DMA ch 3)
>       [3] - 0, 10=10MHz clock for 8254
> -              1= 1MHz clock for 8254
> +	      1= 1MHz clock for 8254
>       [4] - 0,  5=D/A output 0-5V  (internal reference -5V)
> -          1, 10=D/A output 0-10V (internal reference -10V)
> -   	  2    =D/A output unknown (external reference)
> +	  1, 10=D/A output 0-10V (internal reference -10V)
> +	  2    =D/A output unknown (external reference)
>
>      Options for PCL-718:
>       [0] - IO Base
>       [1] - IRQ	(0=disable, 2, 3, 4, 5, 6, 7)
>       [2] - DMA	(0=disable, 1, 3)
>       [3] - 0, 10=10MHz clock for 8254
> -              1= 1MHz clock for 8254
> +	      1= 1MHz clock for 8254
>       [4] -     0=A/D Range is +/-10V
>   	      1=             +/-5V
>   	      2=             +/-2.5V
> @@ -87,14 +87,14 @@ A word or two about DMA. Driver support DMA operations at two ways:
>   	      5=  	     user defined bipolar
>   	      6=	     0-10V
>   	      7=	     0-5V
> - 	      8=	     0-2V
> +	      8=	     0-2V
>   	      9=	     0-1V
>   	     10=	     user defined unipolar
>       [5] - 0,  5=D/A outputs 0-5V  (internal reference -5V)
> -          1, 10=D/A outputs 0-10V (internal reference -10V)
> +	  1, 10=D/A outputs 0-10V (internal reference -10V)
>   	      2=D/A outputs unknown (external reference)
>       [6] - 0, 60=max  60kHz A/D sampling
> -          1,100=max 100kHz A/D sampling (PCL-718 with Option 001 installed)
> +	  1,100=max 100kHz A/D sampling (PCL-718 with Option 001 installed)
>
>   */

Okay, but this comment block really needs reformatting to use the usual 
block comment style, and with spaces to line up the columns instead of 
tabs so it still looks okay when the " * " is removed from the start of 
each line of the block comment.

Reviewed-by: Ian Abbott <abbotti@mev.co.uk>

-- 
-=( Ian Abbott @ MEV Ltd.    E-mail: <abbotti@mev.co.uk> )=-
-=(                          Web: http://www.mev.co.uk/  )=-

  reply	other threads:[~2015-01-26 11:31 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-01-25  9:28 Simon Guo
2015-01-26 11:31 ` Ian Abbott [this message]
2015-01-26 12:52   ` Simon Guo
2015-01-26 13:16 Simon Guo
2015-01-26 14:46 ` Ian Abbott
2015-01-28 19:21 ` Greg Kroah-Hartman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=54C625A3.4020001@mev.co.uk \
    --to=abbotti@mev.co.uk \
    --cc=devel@driverdev.osuosl.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=hsweeten@visionengravers.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=wei.guo.simon@gmail.com \
    --subject='Re: [PATCH 3.19.0-rc5 01/03] STAGING: Fix pcl818.c coding style issue: code indent should use tabs where possible' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).