LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Ian Abbott <abbotti@mev.co.uk>
To: Simon Guo <wei.guo.simon@gmail.com>,
	H Hartley Sweeten <hsweeten@visionengravers.com>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3.19.0-rc5 02/03] STAGING: Fix pcl818.c coding style issue: line over 80 characters
Date: Mon, 26 Jan 2015 11:38:22 +0000	[thread overview]
Message-ID: <54C6272E.4020509@mev.co.uk> (raw)
In-Reply-To: <20150125093042.GB4076@thunderCat>

On 25/01/15 09:30, Simon Guo wrote:
> Correct one coding style problem(detected by checkpatch.pl) in pcl818.c.
> - line over 80 characters
>
> Signed-off-by: Simon Guo <wei.guo.simon@gmail.com>
> ---
>   drivers/staging/comedi/drivers/pcl818.c | 14 ++++++++++----
>   1 file changed, 10 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/staging/comedi/drivers/pcl818.c b/drivers/staging/comedi/drivers/pcl818.c
> index 72a700c..0873617 100644
> --- a/drivers/staging/comedi/drivers/pcl818.c
> +++ b/drivers/staging/comedi/drivers/pcl818.c
> @@ -304,9 +304,13 @@ static const struct pcl818_board boardtypes[] = {
>
>   struct pcl818_private {
>   	struct comedi_isadma *dma;
> -	unsigned int ns_min;	/*  manimal allowed delay between samples (in us) for actual card */
> +	unsigned int ns_min;	/*  manimal allowed delay between samples
> +				 *  (in us) for actual card
> +				 */

I'm not entirely sure what the preferred way of wrapping those comments 
is, but in other places in the comedi code we've been moving such 
comments to the previous line.

>   	int i8253_osc_base;	/*  1/frequency of on board oscilator in ns */
> -	unsigned int act_chanlist[16];	/*  MUX setting for actual AI operations */
> +	unsigned int act_chanlist[16];	/*  MUX setting for actual
> +					 *  AI operations
> +					 */
>   	unsigned int act_chanlist_len;	/*  how long is actual MUX list */
>   	unsigned int act_chanlist_pos;	/*  actual position in MUX list */
>   	unsigned int divisor1;
> @@ -648,7 +652,8 @@ static int check_channel_list(struct comedi_device *dev,
>   				break;
>   			nowmustbechan =
>   			    (CR_CHAN(chansegment[i - 1]) + 1) % s->n_chan;
> -			if (nowmustbechan != CR_CHAN(chanlist[i])) {	/*  channel list isn't continuous :-( */
> +			if (nowmustbechan != CR_CHAN(chanlist[i])) {
> +				/*  channel list isn't continuous :-( */
>   				dev_dbg(dev->class_dev,
>   					"channel list must be continuous! chanlist[%i]=%d but must be %d or %d!\n",
>   					i, CR_CHAN(chanlist[i]), nowmustbechan,
> @@ -1154,8 +1159,9 @@ static int pcl818_attach(struct comedi_device *dev, struct comedi_devconfig *it)
>   	devpriv->ns_min = board->ns_min;
>
>   	if (!board->is_818) {
> +		/* extended PCL718 to 100kHz DAC */
>   		if ((it->options[6] == 1) || (it->options[6] == 100))
> -			devpriv->ns_min = 10000;	/* extended PCL718 to 100kHz DAC */
> +			devpriv->ns_min = 10000;

That comment really belongs inside the 'if' like this:

		if ((it->options[6] == 1) || (it->options[6] == 100)) {
			/* extended PCL718 to 100kHz DAC */
			devpriv->ns_min = 10000;
		}

>   	}
>
>   	pcl818_reset(dev);
>


-- 
-=( Ian Abbott @ MEV Ltd.    E-mail: <abbotti@mev.co.uk> )=-
-=(                          Web: http://www.mev.co.uk/  )=-

  reply	other threads:[~2015-01-26 11:38 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-01-25  9:30 Simon Guo
2015-01-26 11:38 ` Ian Abbott [this message]
2015-01-26 13:17 Simon Guo
2015-01-26 14:47 ` Ian Abbott

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=54C6272E.4020509@mev.co.uk \
    --to=abbotti@mev.co.uk \
    --cc=devel@driverdev.osuosl.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=hsweeten@visionengravers.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=wei.guo.simon@gmail.com \
    --subject='Re: [PATCH 3.19.0-rc5 02/03] STAGING: Fix pcl818.c coding style issue: line over 80 characters' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).