From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754557AbbAZLil (ORCPT ); Mon, 26 Jan 2015 06:38:41 -0500 Received: from smtp-out-156.synserver.de ([212.40.185.156]:1056 "EHLO smtp-out-156.synserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754150AbbAZLii (ORCPT ); Mon, 26 Jan 2015 06:38:38 -0500 X-SynServer-TrustedSrc: 1 X-SynServer-AuthUser: lars@metafoo.de X-SynServer-PPID: 8575 Message-ID: <54C62739.6090902@metafoo.de> Date: Mon, 26 Jan 2015 12:38:33 +0100 From: Lars-Peter Clausen User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Icedove/31.4.0 MIME-Version: 1.0 To: Zubair Lutfullah Kakakhel , tiwai@suse.de, perex@perex.cz CC: devicetree@vger.kernel.org, alsa-devel@alsa-project.org, broonie@kernel.org, lgirdwood@gmail.com, linux-kernel@vger.kernel.org Subject: Re: [alsa-devel] [PATCH 2/4] dt: sound: jz4740: Add binding documentation for jz4740-i2s References: <1422267511-6649-1-git-send-email-Zubair.Kakakhel@imgtec.com> <1422267511-6649-3-git-send-email-Zubair.Kakakhel@imgtec.com> <54C618ED.1090909@metafoo.de> <54C625DE.7030500@imgtec.com> In-Reply-To: <54C625DE.7030500@imgtec.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 01/26/2015 12:32 PM, Zubair Lutfullah Kakakhel wrote: > > On 26/01/15 10:37, Lars-Peter Clausen wrote: >> On 01/26/2015 11:18 AM, Zubair Lutfullah Kakakhel wrote: >> [...] >>> +Required properties: >>> +- compatible : "ingenic,jz4740-i2s" >>> +- reg : I2S registers location and length >>> +- clocks : AIC and I2S PLL clock specifiers. >>> +- clock-names: "aic" and "i2s" >> >> We also need a handle to the DMA channels. Currently the request ids are hardcoded in the driver, but that needs to go away once the driver starts to support multiple SoCs with different request lines. > > I know. I've left DMA until we push the jz4780-dma driver upstream and see how things fit.. It doesn't hurt to put it in the spec. It will be two DMA channels one for rx, one for tx. See for example Documentation/devicetree/bindings/sound/bcm2835-i2s.txt - Lars