LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Lars-Peter Clausen <lars@metafoo.de>
To: Zubair Lutfullah Kakakhel <Zubair.Kakakhel@imgtec.com>,
tiwai@suse.de, perex@perex.cz
Cc: devicetree@vger.kernel.org, alsa-devel@alsa-project.org,
broonie@kernel.org, lgirdwood@gmail.com,
linux-kernel@vger.kernel.org
Subject: Re: [alsa-devel] [PATCH 4/4] sound: jz4740: Enable codec clock during dai_probe
Date: Mon, 26 Jan 2015 12:42:39 +0100 [thread overview]
Message-ID: <54C6282F.5010507@metafoo.de> (raw)
In-Reply-To: <54C62570.5050600@imgtec.com>
On 01/26/2015 12:30 PM, Zubair Lutfullah Kakakhel wrote:
>
> On 26/01/15 10:40, Lars-Peter Clausen wrote:
>> On 01/26/2015 11:18 AM, Zubair Lutfullah Kakakhel wrote:
>>> As we are moving away from platform to DT, we cant rely on the board
>>> file to do this now. So enable it here.
>>
>> I don't understand this changelog. The board file never did this. The driver enables the clock in the startup() callback.
>
> My bad.
>
> I couldn't get the ci20 audio to work without this change.
>
> I double checked. The clock is indeed enabled.
>
> But the rate needs to be set for the ci20.
>
> clk_set_rate(i2s->clk_i2s, 12000000);
>
> Where should I put it? I couldn’t trace how the rate is set for the jz4740..
There is no support for specifying clock rate defaults in the devicetree
itself. See commit 86be408bfbd8 ("clk: Support for clock parents and rates
assigned from device tree"). Since the preferred or correct clock rate will
be board specific this is probably where it should go.
- Lars
prev parent reply other threads:[~2015-01-26 11:42 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-26 10:18 [PATCH 0/4] sound:soc: jz4740: DT, dynamic sampling, enable clocks Zubair Lutfullah Kakakhel
2015-01-26 10:18 ` [PATCH 1/4] sound: soc: jz4740: Add dynamic sampling rate support to jz4740-i2s Zubair Lutfullah Kakakhel
2015-01-26 10:35 ` Lars-Peter Clausen
2015-01-26 10:18 ` [PATCH 2/4] dt: sound: jz4740: Add binding documentation for jz4740-i2s Zubair Lutfullah Kakakhel
2015-01-26 10:37 ` Lars-Peter Clausen
2015-01-26 11:32 ` Zubair Lutfullah Kakakhel
2015-01-26 11:38 ` [alsa-devel] " Lars-Peter Clausen
2015-01-26 11:56 ` Arnd Bergmann
2015-01-26 10:18 ` [PATCH 3/4] sound: soc: jz4740: Add DT support to jz4740-i2s driver Zubair Lutfullah Kakakhel
2015-01-26 10:18 ` [PATCH 4/4] sound: jz4740: Enable codec clock during dai_probe Zubair Lutfullah Kakakhel
2015-01-26 10:40 ` Lars-Peter Clausen
2015-01-26 11:30 ` Zubair Lutfullah Kakakhel
2015-01-26 11:42 ` Lars-Peter Clausen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54C6282F.5010507@metafoo.de \
--to=lars@metafoo.de \
--cc=Zubair.Kakakhel@imgtec.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=perex@perex.cz \
--cc=tiwai@suse.de \
--subject='Re: [alsa-devel] [PATCH 4/4] sound: jz4740: Enable codec clock during dai_probe' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).