LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
* [RFC PATCH] fbcon: Remove unused vblank cursor code
@ 2015-01-23 22:55 Scot Doyle
  2015-01-26 12:11 ` Tomi Valkeinen
  0 siblings, 1 reply; 2+ messages in thread
From: Scot Doyle @ 2015-01-23 22:55 UTC (permalink / raw)
  To: Jean-Christophe Plagniol-Villard, Tomi Valkeinen
  Cc: linux-fbdev, linux-kernel

commit 1fa0b29f3a43 ("fbdev: Kill Atari vblank cursor blinking")

rendered vbl_cursor_cnt and therefore CURSOR_DRAW_DELAY unused in fbcon.c,
so remove them.

Signed-off-by: Scot Doyle <lkml14@scotdoyle.com>
---
 drivers/video/console/fbcon.c | 4 ----
 1 file changed, 4 deletions(-)

diff --git a/drivers/video/console/fbcon.c b/drivers/video/console/fbcon.c
index ea43724..b972106 100644
--- a/drivers/video/console/fbcon.c
+++ b/drivers/video/console/fbcon.c
@@ -146,9 +146,6 @@ static const struct consw fb_con;
 
 static int fbcon_set_origin(struct vc_data *);
 
-#define CURSOR_DRAW_DELAY		(1)
-
-static int vbl_cursor_cnt;
 static int fbcon_cursor_noblink;
 
 #define divides(a, b)	((!(a) || (b)%(a)) ? 0 : 1)
@@ -1329,7 +1326,6 @@ static void fbcon_cursor(struct vc_data *vc, int mode)
 
 	ops->cursor(vc, info, mode, y, get_color(vc, info, c, 1),
 		    get_color(vc, info, c, 0));
-	vbl_cursor_cnt = CURSOR_DRAW_DELAY;
 }
 
 static int scrollback_phys_max = 0;
-- 
2.1.4


^ permalink raw reply related	[flat|nested] 2+ messages in thread
* Re: [RFC PATCH] fbcon: Remove unused vblank cursor code
  2015-01-23 22:55 [RFC PATCH] fbcon: Remove unused vblank cursor code Scot Doyle
@ 2015-01-26 12:11 ` Tomi Valkeinen
  0 siblings, 0 replies; 2+ messages in thread
From: Tomi Valkeinen @ 2015-01-26 12:11 UTC (permalink / raw)
  To: Scot Doyle, Jean-Christophe Plagniol-Villard; +Cc: linux-fbdev, linux-kernel

[-- Attachment #1: Type: text/plain, Size: 1149 bytes --]

On 24/01/15 00:55, Scot Doyle wrote:
> commit 1fa0b29f3a43 ("fbdev: Kill Atari vblank cursor blinking")
> 
> rendered vbl_cursor_cnt and therefore CURSOR_DRAW_DELAY unused in fbcon.c,
> so remove them.
> 
> Signed-off-by: Scot Doyle <lkml14@scotdoyle.com>
> ---
>  drivers/video/console/fbcon.c | 4 ----
>  1 file changed, 4 deletions(-)
> 
> diff --git a/drivers/video/console/fbcon.c b/drivers/video/console/fbcon.c
> index ea43724..b972106 100644
> --- a/drivers/video/console/fbcon.c
> +++ b/drivers/video/console/fbcon.c
> @@ -146,9 +146,6 @@ static const struct consw fb_con;
>  
>  static int fbcon_set_origin(struct vc_data *);
>  
> -#define CURSOR_DRAW_DELAY		(1)
> -
> -static int vbl_cursor_cnt;
>  static int fbcon_cursor_noblink;
>  
>  #define divides(a, b)	((!(a) || (b)%(a)) ? 0 : 1)
> @@ -1329,7 +1326,6 @@ static void fbcon_cursor(struct vc_data *vc, int mode)
>  
>  	ops->cursor(vc, info, mode, y, get_color(vc, info, c, 1),
>  		    get_color(vc, info, c, 0));
> -	vbl_cursor_cnt = CURSOR_DRAW_DELAY;
>  }
>  
>  static int scrollback_phys_max = 0;
> 

Thanks, queued for 3.20.

 Tomi



[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

^ permalink raw reply	[flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-01-26 12:11 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-01-23 22:55 [RFC PATCH] fbcon: Remove unused vblank cursor code Scot Doyle
2015-01-26 12:11 ` Tomi Valkeinen

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).