LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Daniel Lezcano <daniel.lezcano@linaro.org>
To: Baruch Siach <baruch@tkos.co.il>
Cc: Thomas Gleixner <tglx@linutronix.de>,
	linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v5 2/2] clocksource: driver for Conexant Digicolor SoC timer
Date: Mon, 26 Jan 2015 14:58:18 +0100	[thread overview]
Message-ID: <54C647FA.7010300@linaro.org> (raw)
In-Reply-To: <20150126134751.GE3148@tarshish>

On 01/26/2015 02:47 PM, Baruch Siach wrote:
> Hi Daniel,
>
> On Mon, Jan 26, 2015 at 02:44:15PM +0100, Daniel Lezcano wrote:
>>> diff --git a/drivers/clocksource/Makefile b/drivers/clocksource/Makefile
>>> index 94d90b24b56b..a993c108be67 100644
>>> --- a/drivers/clocksource/Makefile
>>> +++ b/drivers/clocksource/Makefile
>>> @@ -10,6 +10,7 @@ obj-$(CONFIG_SH_TIMER_TMU)	+= sh_tmu.o
>>>   obj-$(CONFIG_EM_TIMER_STI)	+= em_sti.o
>>>   obj-$(CONFIG_CLKBLD_I8253)	+= i8253.o
>>>   obj-$(CONFIG_CLKSRC_MMIO)	+= mmio.o
>>> +obj-$(CONFIG_ARCH_DIGICOLOR)	+= timer-digicolor.o
>>
>> Ah, one minor change I forgot to mention in the last review (sorry about
>> that).
>>
>> Don't depend on the ARCH, add and select a TIMER_DIGICOLOR (or whatever the
>> name you prefer) in the mach-digicolor/Kconfig and use it here.
>
> OK. I'll make the change. I'm just curious: what is the advantage of having a
> separate config symbol for the timer?

It is because some timers could be used in different platforms, so the 
policy of the house is to let the platform Kconfig to select the timer.

Also, that let one platform to not select the timer if it is not needed. 
For example one SoC uses the architected timers and there is not power 
management on the board, hence no cpu is powered down and no backup 
timer is needed.

Even if the timer is expected to be used on only one platform, we try to 
keep the rule consistent across the different drivers (even if I admit 
some cleanups should be done in the Kconfig file).



-- 
  <http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs

Follow Linaro:  <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog


      reply	other threads:[~2015-01-26 13:58 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-01-26 11:57 [PATCH v5 0/2] clocksource: Conexant CX92755 timers support Baruch Siach
2015-01-26 11:57 ` [PATCH v5 1/2] clocksource: devicetree: document Conexant Digicolor timer binding Baruch Siach
2015-01-26 11:57 ` [PATCH v5 2/2] clocksource: driver for Conexant Digicolor SoC timer Baruch Siach
2015-01-26 13:44   ` Daniel Lezcano
2015-01-26 13:47     ` Baruch Siach
2015-01-26 13:58       ` Daniel Lezcano [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=54C647FA.7010300@linaro.org \
    --to=daniel.lezcano@linaro.org \
    --cc=baruch@tkos.co.il \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=tglx@linutronix.de \
    --subject='Re: [PATCH v5 2/2] clocksource: driver for Conexant Digicolor SoC timer' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).