LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: "Andreas Färber" <afaerber@suse.de>
To: "Sören Brinkmann" <soren.brinkmann@xilinx.com>
Cc: monstr@monstr.eu, Michal Simek <michal.simek@xilinx.com>,
	devicetree@vger.kernel.org,
	Peter Crosthwaite <peter.crosthwaite@xilinx.com>,
	Arnd Bergmann <arnd@arndb.de>,
	linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	Ola Jeppson <ola@adapteva.com>
Subject: Re: [PATCH v3] ARM: zynq: DT: Add USB to device tree
Date: Mon, 26 Jan 2015 17:21:35 +0100	[thread overview]
Message-ID: <54C6698F.5020301@suse.de> (raw)
In-Reply-To: <c65880cef67945ebaf61306febc1349b@BN1BFFO11FD010.protection.gbl>

[-- Attachment #1: Type: text/plain, Size: 4411 bytes --]

Am 26.01.2015 um 16:50 schrieb Sören Brinkmann:
> On Mon, 2015-01-26 at 10:35AM +0100, Andreas Färber wrote:
>> Am 26.01.2015 um 09:33 schrieb Andreas Färber:
>>> Am 26.01.2015 um 09:23 schrieb Michal Simek:
>>>> On 01/26/2015 09:19 AM, Andreas Färber wrote:
>>>>> And if I apply it to my -next based tree, adding corresponding nodes to
>>>>> zynq-parallella.dts, I get repeatedly:
>>>>>
>>>>> [  +0,012242] ci_hdrc ci_hdrc.0: no of_node; not parsing pinctrl DT
>>>>> [  +0,000157] ci_hdrc ci_hdrc.0: ChipIdea HDRC found, lpm: 0; cap:
>>>>> f090e100 op: f090e140
>>>>> [  +0,000081] platform ci_hdrc.0: Driver ci_hdrc requests probe deferral
>>>>> [  +0,005360] ci_hdrc ci_hdrc.1: no of_node; not parsing pinctrl DT
>>>>> [  +0,000120] ci_hdrc ci_hdrc.1: ChipIdea HDRC found, lpm: 0; cap:
>>>>> f0910100 op: f0910140
>>>>> [  +0,001810] platform ci_hdrc.1: Driver ci_hdrc requests probe deferral
>>>>>
>>>>> Am I missing any other patches or config options?
>>>>> (I do notice that the pinctrl v3 patch that got merged has a trivial bug
>>>>> for usb0, for which I'll send a patch later on.)
>>>>
>>>> Why is it deferred? Is it because of pinmuxing stuff?
>>>
>>> No, happened without as well.
>>>
>>> Looking at a different place in dmesg, I spot this:
>>>
>>> [  +0,003988] usb_phy_generic phy0: GPIO lookup for consumer reset-gpios
>>> [  +0,000012] usb_phy_generic phy0: using device tree for GPIO lookup
>>> [  +0,000015] of_get_named_gpiod_flags: can't parse 'reset-gpios-gpios'
>>> property
>>>  of node '/phy0[0]'
>>> [  +0,000013] of_get_named_gpiod_flags: can't parse 'reset-gpios-gpio'
>>> property
>>> of node '/phy0[0]'
>>> [  +0,000010] usb_phy_generic phy0: using lookup tables for GPIO lookup
>>> [  +0,000153] usb_phy_generic phy0: lookup for GPIO reset-gpios failed
>>> [  +0,000012] usb_phy_generic phy0: Error requesting RESET GPIO
>>> [  +0,004360] usb_phy_generic: probe of phy0 failed with error -2
>>> [  +0,004991] usb_phy_generic phy1: GPIO lookup for consumer reset-gpios
>>> [  +0,000012] usb_phy_generic phy1: using device tree for GPIO lookup
>>> [  +0,000013] of_get_named_gpiod_flags: can't parse 'reset-gpios-gpios'
>>> property
>>>  of node '/phy1[0]'
>>> [  +0,000013] of_get_named_gpiod_flags: can't parse 'reset-gpios-gpio'
>>> property of node '/phy1[0]'
>>> [  +0,000010] usb_phy_generic phy1: using lookup tables for GPIO lookup
>>> [  +0,000012] usb_phy_generic phy1: lookup for GPIO reset-gpios failed
>>> [  +0,000011] usb_phy_generic phy1: Error requesting RESET GPIO
>>> [  +0,004337] usb_phy_generic: probe of phy1 failed with error -2
>>>
>>> So, I guess the chipidea driver is deferring because the phys want a
>>> property that neither me nor you are specifying? Would that be the two
>>> MDIO pins 52 and 53 that would need to be specified?
>>
>> Erm, scratch that last question - wrong PHY. Trying it resolved the
>> above phy errors but not the original problem. And so does an empty one:
>>
>> @@ -99,11 +100,13 @@
>>
>>         usb_phy0: phy0 {
>>                 compatible = "usb-nop-xceiv";
>> +               reset-gpios = <>;
>>                 #phy-cells = <0>;
>>         };
>>
>>         usb_phy1: phy1 {
>>                 compatible = "usb-nop-xceiv";
>> +               reset-gpios = <>;
>>                 #phy-cells = <0>;
>>         };
>>  };
>>
>> In my manuals and notes I can't find any GPIO being used as reset for
>> the USB PHYs. Any thoughts appreciated.
> 
> Such a connection is optional. The platform might rely on its reset
> circuit, though it might not work for warm reboots.
> I haven't looked at parallela docs, but if there is a schematic
> available, that should tell you if/what is connected to the PHY reset
> pin.

I do have the schematic, and the way I read it, only the on-board reset
button resets the PHYs.

Yet it looks as if usb-nop-xceiv insists on a reset-gpios above, no?
Does it work on your boards with linux-next?

And regarding my previous reporting, I was mistaken: I had to increase
the log buffer size due to enabled pinctrl debugging, which made the phy
errors sometimes appear, depending on timing. They're still there.

Andreas

-- 
SUSE Linux GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Felix Imendörffer, Jane Smithard, Jennifer Guild, Dilip Upmanyu,
Graham Norton; HRB 21284 (AG Nürnberg)


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

  reply	other threads:[~2015-01-26 16:21 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-12-02 16:07 Soren Brinkmann
2014-12-03  8:39 ` Michal Simek
2015-01-26  8:19   ` Andreas Färber
2015-01-26  8:23     ` Michal Simek
2015-01-26  8:33       ` Andreas Färber
2015-01-26  9:35         ` Andreas Färber
2015-01-26 15:50           ` Sören Brinkmann
2015-01-26 16:21             ` Andreas Färber [this message]
2015-01-26 16:23               ` Sören Brinkmann
2015-01-26 18:44                 ` Sören Brinkmann
2015-01-27  1:14                   ` Andreas Färber
2015-01-27  1:20                     ` Sören Brinkmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=54C6698F.5020301@suse.de \
    --to=afaerber@suse.de \
    --cc=arnd@arndb.de \
    --cc=devicetree@vger.kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=michal.simek@xilinx.com \
    --cc=monstr@monstr.eu \
    --cc=ola@adapteva.com \
    --cc=peter.crosthwaite@xilinx.com \
    --cc=soren.brinkmann@xilinx.com \
    --subject='Re: [PATCH v3] ARM: zynq: DT: Add USB to device tree' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).