LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: Zubair Lutfullah Kakakhel <Zubair.Kakakhel@imgtec.com>,
	stern@rowland.harvard.edu
Cc: gregkh@linuxfoundation.org, lars@metafoo.de,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-usb@vger.kernel.org
Subject: Re: [PATCH 1/3] dt: usb: jz4740: Add DT binding document for OHCI
Date: Tue, 27 Jan 2015 19:30:53 +0300	[thread overview]
Message-ID: <54C7BD3D.4010707@cogentembedded.com> (raw)
In-Reply-To: <1422366439-34641-2-git-send-email-Zubair.Kakakhel@imgtec.com>

Hello.

On 01/27/2015 04:47 PM, Zubair Lutfullah Kakakhel wrote:

> From: Paul Burton <paul.burton@imgtec.com>

> Add the binding documentation for the JZ47xx OHCI controller.

> Signed-off-by: Paul Burton <paul.burton@imgtec.com>
> Signed-off-by: Zubair Lutfullah Kakakhel <Zubair.Kakakhel@imgtec.com>

> ---
> The jz4740 is platform only at the moment.

> But DT support is being added

> See http://patchwork.linux-mips.org/bundle/paulburton/ci20-v3.20/

> jz47xx is used because jz4780 will also use this driver
> ---
>   .../bindings/usb/ingenic,jz47xx-ohci.txt           | 28 ++++++++++++++++++++++
>   1 file changed, 28 insertions(+)
>   create mode 100644 Documentation/devicetree/bindings/usb/ingenic,jz47xx-ohci.txt

> diff --git a/Documentation/devicetree/bindings/usb/ingenic,jz47xx-ohci.txt b/Documentation/devicetree/bindings/usb/ingenic,jz47xx-ohci.txt
> new file mode 100644
> index 0000000..2fada8b
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/usb/ingenic,jz47xx-ohci.txt
> @@ -0,0 +1,28 @@
> +Ingenic JZ47XX SoC OHCI controller binding

    I think JZ47xx would look a bit better.

> +
> +The Ingenic JZ47XX SoC includes an OHCI compliant USB host controller
> +interface for use with USB 1.1 devices.
> +
> +Required properties:
> + - compatible: Should be "ingenic,jz4740-ohci"
> + - reg: Should contain the address & size of the OHCI controller registers.
> + - interrupt-parent: Should be the phandle of the interrupt controller that
> +   delivers interrupts to the OHCI block.

    This is never a required prop, it can be inherited from a parent node.

> + - interrupts: Should specify the interrupt provided by interrupt-parent.
> + - clocks: Should contain a single clock specifier for the SoC UHC clock.
> +
> +Example SoC include file for jz4780:
> +
> +/ {
> +	ohci: jz4780-ohci@0x134a0000 {

    The ePAPR standard says we shouldn't name the nodes after the chips used 
but use the generic names, which would be "usb" in this case. And please drop 
"0x" from the <unit-address> part of the name.

> +		compatible = "ingenic,jz4780-ohci";
> +		reg = <0x134a0000 0x10000>;
> +
> +		interrupt-parent = <&intc>;
> +		interrupts = <5>;
> +
> +		clocks = <&cgu JZ4780_CLK_UHC>;
> +		clock-names = "uhc";

    You forgot to mention this prop above.

[...]

WBR, Sergei


  reply	other threads:[~2015-01-27 16:31 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-01-27 13:47 [PATCH 0/3] usb: ohci: jz4740: Add DT support and a fix Zubair Lutfullah Kakakhel
2015-01-27 13:47 ` [PATCH 1/3] dt: usb: jz4740: Add DT binding document for OHCI Zubair Lutfullah Kakakhel
2015-01-27 16:30   ` Sergei Shtylyov [this message]
2015-01-27 13:47 ` [PATCH 2/3] usb: ohci: jz4740: add DT support Zubair Lutfullah Kakakhel
2015-01-27 13:47 ` [PATCH 3/3] usb: ohci: jz4740: prepare the clock before enabling it Zubair Lutfullah Kakakhel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=54C7BD3D.4010707@cogentembedded.com \
    --to=sergei.shtylyov@cogentembedded.com \
    --cc=Zubair.Kakakhel@imgtec.com \
    --cc=devicetree@vger.kernel.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=lars@metafoo.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=stern@rowland.harvard.edu \
    --subject='Re: [PATCH 1/3] dt: usb: jz4740: Add DT binding document for OHCI' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).