LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
* [PATCH] mtd: export new mtd_mmap_capabilities
@ 2015-01-28 15:19 Arnd Bergmann
  2015-01-28 16:55 ` Christoph Hellwig
  2015-01-28 18:05 ` Brian Norris
  0 siblings, 2 replies; 4+ messages in thread
From: Arnd Bergmann @ 2015-01-28 15:19 UTC (permalink / raw)
  To: linux-mtd, Brian Norris, David Woodhouse
  Cc: Christoph Hellwig, Tejun Heo, Jens Axboe, linux-kernel, linux-arm-kernel

The recently added mtd_mmap_capabilities can be used from loadable
modules, in particular romfs, but is not exported, so we get

ERROR: "mtd_mmap_capabilities" [fs/romfs/romfs.ko] undefined!

This adds the missing export.

Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Fixes: b4caecd48005f ("fs: introduce f_op->mmap_capabilities for nommu mmap support")

diff --git a/drivers/mtd/mtdcore.c b/drivers/mtd/mtdcore.c
index 1eef3b032f08..de7957681680 100644
--- a/drivers/mtd/mtdcore.c
+++ b/drivers/mtd/mtdcore.c
@@ -365,6 +365,7 @@ unsigned mtd_mmap_capabilities(struct mtd_info *mtd)
 		return NOMMU_MAP_COPY;
 	}
 }
+EXPORT_SYMBOL_GPL(mtd_mmap_capabilities);
 #endif
 
 /**


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] mtd: export new mtd_mmap_capabilities
  2015-01-28 15:19 [PATCH] mtd: export new mtd_mmap_capabilities Arnd Bergmann
@ 2015-01-28 16:55 ` Christoph Hellwig
  2015-01-28 18:05 ` Brian Norris
  1 sibling, 0 replies; 4+ messages in thread
From: Christoph Hellwig @ 2015-01-28 16:55 UTC (permalink / raw)
  To: Arnd Bergmann
  Cc: linux-mtd, Brian Norris, David Woodhouse, Christoph Hellwig,
	Tejun Heo, Jens Axboe, linux-kernel, linux-arm-kernel

On Wed, Jan 28, 2015 at 04:19:31PM +0100, Arnd Bergmann wrote:
> The recently added mtd_mmap_capabilities can be used from loadable
> modules, in particular romfs, but is not exported, so we get
> 
> ERROR: "mtd_mmap_capabilities" [fs/romfs/romfs.ko] undefined!
> 
> This adds the missing export.
> 
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> Fixes: b4caecd48005f ("fs: introduce f_op->mmap_capabilities for nommu mmap support")

Thanks, this looks fine to me:

Acked-by: Christoph Hellwig <hch@lst.de>

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] mtd: export new mtd_mmap_capabilities
  2015-01-28 15:19 [PATCH] mtd: export new mtd_mmap_capabilities Arnd Bergmann
  2015-01-28 16:55 ` Christoph Hellwig
@ 2015-01-28 18:05 ` Brian Norris
  2015-01-28 18:09   ` Jens Axboe
  1 sibling, 1 reply; 4+ messages in thread
From: Brian Norris @ 2015-01-28 18:05 UTC (permalink / raw)
  To: Arnd Bergmann
  Cc: linux-mtd, David Woodhouse, Christoph Hellwig, Tejun Heo,
	Jens Axboe, linux-kernel, linux-arm-kernel

On Wed, Jan 28, 2015 at 04:19:31PM +0100, Arnd Bergmann wrote:
> The recently added mtd_mmap_capabilities can be used from loadable
> modules, in particular romfs, but is not exported, so we get
> 
> ERROR: "mtd_mmap_capabilities" [fs/romfs/romfs.ko] undefined!
> 
> This adds the missing export.
> 
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> Fixes: b4caecd48005f ("fs: introduce f_op->mmap_capabilities for nommu mmap support")

Acked-by: Brian Norris <computersforpeace@gmail.com>

This should go through the block tree in which the target commit is
queued.

Brian

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] mtd: export new mtd_mmap_capabilities
  2015-01-28 18:05 ` Brian Norris
@ 2015-01-28 18:09   ` Jens Axboe
  0 siblings, 0 replies; 4+ messages in thread
From: Jens Axboe @ 2015-01-28 18:09 UTC (permalink / raw)
  To: Brian Norris, Arnd Bergmann
  Cc: linux-mtd, David Woodhouse, Christoph Hellwig, Tejun Heo,
	linux-kernel, linux-arm-kernel

On 01/28/2015 11:05 AM, Brian Norris wrote:
> On Wed, Jan 28, 2015 at 04:19:31PM +0100, Arnd Bergmann wrote:
>> The recently added mtd_mmap_capabilities can be used from loadable
>> modules, in particular romfs, but is not exported, so we get
>>
>> ERROR: "mtd_mmap_capabilities" [fs/romfs/romfs.ko] undefined!
>>
>> This adds the missing export.
>>
>> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
>> Fixes: b4caecd48005f ("fs: introduce f_op->mmap_capabilities for nommu mmap support")
>
> Acked-by: Brian Norris <computersforpeace@gmail.com>
>
> This should go through the block tree in which the target commit is
> queued.

Applied to for-3.20/bdi, thanks Arnd.

-- 
Jens Axboe


^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2015-01-29  1:51 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-01-28 15:19 [PATCH] mtd: export new mtd_mmap_capabilities Arnd Bergmann
2015-01-28 16:55 ` Christoph Hellwig
2015-01-28 18:05 ` Brian Norris
2015-01-28 18:09   ` Jens Axboe

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).