LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Hans Verkuil <hansverk@cisco.com>
To: Davidlohr Bueso <dave@stgolabs.net>,
	Shuah Khan <shuahkh@osg.samsung.com>
Cc: m.chehab@samsung.com, hans.verkuil@cisco.com,
	dheitmueller@kernellabs.com, prabhakar.csengg@gmail.com,
	sakari.ailus@linux.intel.com, laurent.pinchart@ideasonboard.com,
	ttmesterr@gmail.com, linux-media@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v5] media: au0828 - convert to use videobuf2
Date: Thu, 29 Jan 2015 12:15:55 +0100	[thread overview]
Message-ID: <54CA166B.6000101@cisco.com> (raw)
In-Reply-To: <1422530027.4604.32.camel@stgolabs.net>



On 01/29/15 12:13, Davidlohr Bueso wrote:
> On Wed, 2015-01-28 at 16:14 -0700, Shuah Khan wrote:
>> On 01/23/2015 12:41 PM, Shuah Khan wrote:
>>> Convert au0828 to use videobuf2. Tested with NTSC.
>>> Tested video and vbi devices with xawtv, tvtime,
>>> and vlc. Ran v4l2-compliance to ensure there are
>>> no failures. 
>>>
>>> Video compliance test results summary:
>>> Total: 75, Succeeded: 75, Failed: 0, Warnings: 18
>>>
>>> Vbi compliance test results summary:
>>> Total: 75, Succeeded: 75, Failed: 0, Warnings: 0
>>>
>>> Signed-off-by: Shuah Khan <shuahkh@osg.samsung.com>
>>> ---
>>
>> Hi Hans,
>>
>> Please don't pull this in. Found a bug in stop_streaming() when
>> re-tuning that requires re-working this patch.
> 
> ... and also:
> 
>  drivers/media/usb/au0828/Kconfig        |   2 +-
>  drivers/media/usb/au0828/au0828-vbi.c   | 122 ++--
>  drivers/media/usb/au0828/au0828-video.c | 962 ++++++++++++--------------------
>  drivers/media/usb/au0828/au0828.h       |  61 +-
>  4 files changed, 443 insertions(+), 704 deletions(-)
> 
> in a single patch. Lets be nice to reviewers, we can spare a few extra
> hash ids.

You can't split this up, it's one of those changes that is all or
nothing.

Regards,

	Hans

  reply	other threads:[~2015-01-29 11:25 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-01-23 19:41 Shuah Khan
2015-01-28 23:14 ` Shuah Khan
2015-01-29 11:13   ` Davidlohr Bueso
2015-01-29 11:15     ` Hans Verkuil [this message]
2015-01-29 11:21       ` Davidlohr Bueso

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=54CA166B.6000101@cisco.com \
    --to=hansverk@cisco.com \
    --cc=dave@stgolabs.net \
    --cc=dheitmueller@kernellabs.com \
    --cc=hans.verkuil@cisco.com \
    --cc=laurent.pinchart@ideasonboard.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=m.chehab@samsung.com \
    --cc=prabhakar.csengg@gmail.com \
    --cc=sakari.ailus@linux.intel.com \
    --cc=shuahkh@osg.samsung.com \
    --cc=ttmesterr@gmail.com \
    --subject='Re: [PATCH v5] media: au0828 - convert to use videobuf2' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).