LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Ian Abbott <abbotti@mev.co.uk>
To: Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>,
	H Hartley Sweeten <hsweeten@visionengravers.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Julia Lawall <julia.lawall@lip6.fr>,
	Heena Sirwani <heenasirwani@gmail.com>,
	devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: comedi: drivers: mite: Removed variables that is never used
Date: Thu, 29 Jan 2015 14:39:56 +0000	[thread overview]
Message-ID: <54CA463C.9090804@mev.co.uk> (raw)
In-Reply-To: <1422484584-9164-1-git-send-email-rickard_strandqvist@spectrumdigital.se>

On 28/01/15 22:36, Rickard Strandqvist wrote:
> Variable ar assigned a value that is never used.
> I have also removed all the code that thereby serves no purpose.
>
> This was found using a static code analysis program called cppcheck
>
> Signed-off-by: Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
> ---
>   drivers/staging/comedi/drivers/mite.c |    3 +--
>   1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/staging/comedi/drivers/mite.c b/drivers/staging/comedi/drivers/mite.c
> index ffc9e61..8d2903b 100644
> --- a/drivers/staging/comedi/drivers/mite.c
> +++ b/drivers/staging/comedi/drivers/mite.c
> @@ -494,9 +494,8 @@ EXPORT_SYMBOL_GPL(mite_bytes_read_from_memory_ub);
>   unsigned mite_dma_tcr(struct mite_channel *mite_chan)
>   {
>   	struct mite_struct *mite = mite_chan->mite;
> -	int lkar;
>
> -	lkar = readl(mite->mite_io_addr + MITE_LKAR(mite_chan->channel));
> +	readl(mite->mite_io_addr + MITE_LKAR(mite_chan->channel));
>   	return readl(mite->mite_io_addr + MITE_TCR(mite_chan->channel));
>   }
>   EXPORT_SYMBOL_GPL(mite_dma_tcr);
>

Reading the MITE_LKAR(channel) register won't have any side-effects, so 
that call to readl() can be removed altogether.  In previous versions of 
the driver, the value of lkar was only used in debugging messages.

-- 
-=( Ian Abbott @ MEV Ltd.    E-mail: <abbotti@mev.co.uk> )=-
-=(                          Web: http://www.mev.co.uk/  )=-

  parent reply	other threads:[~2015-01-29 14:40 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-01-28 22:36 Rickard Strandqvist
2015-01-28 22:36 ` Julia Lawall
2015-01-29 14:39 ` Ian Abbott [this message]
2015-01-29 22:18   ` Rickard Strandqvist

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=54CA463C.9090804@mev.co.uk \
    --to=abbotti@mev.co.uk \
    --cc=devel@driverdev.osuosl.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=heenasirwani@gmail.com \
    --cc=hsweeten@visionengravers.com \
    --cc=julia.lawall@lip6.fr \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rickard_strandqvist@spectrumdigital.se \
    --subject='Re: [PATCH] staging: comedi: drivers: mite: Removed variables that is never used' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).