LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
* [PATCH] staging: comedi: drivers: ni_mio_cs: Removed variables that is never used
@ 2015-01-28 22:37 Rickard Strandqvist
  2015-01-29 14:46 ` Ian Abbott
  0 siblings, 1 reply; 2+ messages in thread
From: Rickard Strandqvist @ 2015-01-28 22:37 UTC (permalink / raw)
  To: Ian Abbott, H Hartley Sweeten
  Cc: Rickard Strandqvist, Greg Kroah-Hartman, devel, linux-kernel

Variable ar assigned a value that is never used.
I have also removed all the code that thereby serves no purpose.

This was found using a static code analysis program called cppcheck

Signed-off-by: Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
---
 drivers/staging/comedi/drivers/ni_mio_cs.c |    3 ---
 1 file changed, 3 deletions(-)

diff --git a/drivers/staging/comedi/drivers/ni_mio_cs.c b/drivers/staging/comedi/drivers/ni_mio_cs.c
index 9b201e4..b152330 100644
--- a/drivers/staging/comedi/drivers/ni_mio_cs.c
+++ b/drivers/staging/comedi/drivers/ni_mio_cs.c
@@ -163,7 +163,6 @@ static int mio_cs_auto_attach(struct comedi_device *dev,
 {
 	struct pcmcia_device *link = comedi_to_pcmcia_dev(dev);
 	static const struct ni_board_struct *board;
-	struct ni_private *devpriv;
 	int ret;
 
 	board = ni_getboardtype(dev, link);
@@ -188,8 +187,6 @@ static int mio_cs_auto_attach(struct comedi_device *dev,
 	if (ret)
 		return ret;
 
-	devpriv = dev->private;
-
 	return ni_E_init(dev, 0, 1);
 }
 
-- 
1.7.10.4


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] staging: comedi: drivers: ni_mio_cs: Removed variables that is never used
  2015-01-28 22:37 [PATCH] staging: comedi: drivers: ni_mio_cs: Removed variables that is never used Rickard Strandqvist
@ 2015-01-29 14:46 ` Ian Abbott
  0 siblings, 0 replies; 2+ messages in thread
From: Ian Abbott @ 2015-01-29 14:46 UTC (permalink / raw)
  To: Rickard Strandqvist, H Hartley Sweeten
  Cc: Greg Kroah-Hartman, devel, linux-kernel

On 28/01/15 22:37, Rickard Strandqvist wrote:
> Variable ar assigned a value that is never used.
> I have also removed all the code that thereby serves no purpose.
>
> This was found using a static code analysis program called cppcheck
>
> Signed-off-by: Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
> ---
>   drivers/staging/comedi/drivers/ni_mio_cs.c |    3 ---
>   1 file changed, 3 deletions(-)
>
> diff --git a/drivers/staging/comedi/drivers/ni_mio_cs.c b/drivers/staging/comedi/drivers/ni_mio_cs.c
> index 9b201e4..b152330 100644
> --- a/drivers/staging/comedi/drivers/ni_mio_cs.c
> +++ b/drivers/staging/comedi/drivers/ni_mio_cs.c
> @@ -163,7 +163,6 @@ static int mio_cs_auto_attach(struct comedi_device *dev,
>   {
>   	struct pcmcia_device *link = comedi_to_pcmcia_dev(dev);
>   	static const struct ni_board_struct *board;
> -	struct ni_private *devpriv;
>   	int ret;
>
>   	board = ni_getboardtype(dev, link);
> @@ -188,8 +187,6 @@ static int mio_cs_auto_attach(struct comedi_device *dev,
>   	if (ret)
>   		return ret;
>
> -	devpriv = dev->private;
> -
>   	return ni_E_init(dev, 0, 1);
>   }
>
>

Yes, devpriv is not needed here.

Reviewed-by: Ian Abbott <abbotti@mev.co.uk>

-- 
-=( Ian Abbott @ MEV Ltd.    E-mail: <abbotti@mev.co.uk> )=-
-=(                          Web: http://www.mev.co.uk/  )=-

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2015-01-29 14:46 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-01-28 22:37 [PATCH] staging: comedi: drivers: ni_mio_cs: Removed variables that is never used Rickard Strandqvist
2015-01-29 14:46 ` Ian Abbott

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).