LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
* [PATCH] firmware: efi: remove unneeded guid unparse
@ 2015-01-29 14:35 Ivan Khoronzhuk
  2015-01-29 14:47 ` Matt Fleming
  0 siblings, 1 reply; 3+ messages in thread
From: Ivan Khoronzhuk @ 2015-01-29 14:35 UTC (permalink / raw)
  To: matt.fleming, linux-efi; +Cc: linux-kernel, Ivan Khoronzhuk

There is no reason to translate guid number to string here.
So remove it in order to not do unneeded work.

Signed-off-by: Ivan Khoronzhuk <ivan.khoronzhuk@linaro.org>
---
 drivers/firmware/efi/efi.c | 5 -----
 1 file changed, 5 deletions(-)

diff --git a/drivers/firmware/efi/efi.c b/drivers/firmware/efi/efi.c
index 9035c1b..f6be017 100644
--- a/drivers/firmware/efi/efi.c
+++ b/drivers/firmware/efi/efi.c
@@ -272,15 +272,10 @@ static __init int match_config_table(efi_guid_t *guid,
 				     unsigned long table,
 				     efi_config_table_type_t *table_types)
 {
-	u8 str[EFI_VARIABLE_GUID_LEN + 1];
 	int i;
 
 	if (table_types) {
-		efi_guid_unparse(guid, str);
-
 		for (i = 0; efi_guidcmp(table_types[i].guid, NULL_GUID); i++) {
-			efi_guid_unparse(&table_types[i].guid, str);
-
 			if (!efi_guidcmp(*guid, table_types[i].guid)) {
 				*(table_types[i].ptr) = table;
 				pr_cont(" %s=0x%lx ",
-- 
1.9.1


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] firmware: efi: remove unneeded guid unparse
  2015-01-29 14:35 [PATCH] firmware: efi: remove unneeded guid unparse Ivan Khoronzhuk
@ 2015-01-29 14:47 ` Matt Fleming
  2015-01-29 14:57   ` Ivan Khoronzhuk
  0 siblings, 1 reply; 3+ messages in thread
From: Matt Fleming @ 2015-01-29 14:47 UTC (permalink / raw)
  To: Ivan Khoronzhuk; +Cc: linux-efi, linux-kernel

On Thu, 2015-01-29 at 16:35 +0200, Ivan Khoronzhuk wrote:
> There is no reason to translate guid number to string here.
> So remove it in order to not do unneeded work.
> 
> Signed-off-by: Ivan Khoronzhuk <ivan.khoronzhuk@linaro.org>
> ---
>  drivers/firmware/efi/efi.c | 5 -----
>  1 file changed, 5 deletions(-)

Why the resend? I already picked this commit up,

  https://lkml.kernel.org/r/20150120223238.GC12079@codeblueprint.co.uk


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] firmware: efi: remove unneeded guid unparse
  2015-01-29 14:47 ` Matt Fleming
@ 2015-01-29 14:57   ` Ivan Khoronzhuk
  0 siblings, 0 replies; 3+ messages in thread
From: Ivan Khoronzhuk @ 2015-01-29 14:57 UTC (permalink / raw)
  To: Matt Fleming; +Cc: linux-efi, linux-kernel

Oh, sorry.
Just didn't note that it's picked up from linaro list.


On 01/29/2015 04:47 PM, Matt Fleming wrote:
> On Thu, 2015-01-29 at 16:35 +0200, Ivan Khoronzhuk wrote:
>> There is no reason to translate guid number to string here.
>> So remove it in order to not do unneeded work.
>>
>> Signed-off-by: Ivan Khoronzhuk <ivan.khoronzhuk@linaro.org>
>> ---
>>   drivers/firmware/efi/efi.c | 5 -----
>>   1 file changed, 5 deletions(-)
> Why the resend? I already picked this commit up,
>
>    https://lkml.kernel.org/r/20150120223238.GC12079@codeblueprint.co.uk
>


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2015-01-29 14:57 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-01-29 14:35 [PATCH] firmware: efi: remove unneeded guid unparse Ivan Khoronzhuk
2015-01-29 14:47 ` Matt Fleming
2015-01-29 14:57   ` Ivan Khoronzhuk

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).