LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
* [PATCH] staging: comedi: drivers: addi-data: hwdrv_apci3501: Removed variables that is never used
@ 2015-01-28 21:51 Rickard Strandqvist
  2015-01-29 15:14 ` Ian Abbott
  0 siblings, 1 reply; 2+ messages in thread
From: Rickard Strandqvist @ 2015-01-28 21:51 UTC (permalink / raw)
  To: Ian Abbott, H Hartley Sweeten
  Cc: Rickard Strandqvist, Greg Kroah-Hartman, Chase Southwood,
	Marcin Kostrzewa, Fred Akers, devel, linux-kernel

Variable ar assigned a value that is never used.
I have also removed all the code that thereby serves no purpose.

This was found using a static code analysis program called cppcheck

Signed-off-by: Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
---
 drivers/staging/comedi/drivers/addi-data/hwdrv_apci3501.c |    3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/staging/comedi/drivers/addi-data/hwdrv_apci3501.c b/drivers/staging/comedi/drivers/addi-data/hwdrv_apci3501.c
index 339519a..24126e3 100644
--- a/drivers/staging/comedi/drivers/addi-data/hwdrv_apci3501.c
+++ b/drivers/staging/comedi/drivers/addi-data/hwdrv_apci3501.c
@@ -93,7 +93,6 @@ static int apci3501_write_insn_timer(struct comedi_device *dev,
 {
 	struct apci3501_private *devpriv = dev->private;
 	unsigned int ul_Command1 = 0;
-	int i_Temp;
 
 	if (devpriv->b_TimerSelectMode == ADDIDATA_WATCHDOG) {
 
@@ -135,7 +134,7 @@ static int apci3501_write_insn_timer(struct comedi_device *dev,
 		}
 	}
 
-	i_Temp = inl(dev->iobase + APCI3501_TIMER_STATUS_REG) & 0x1;
+	inl(dev->iobase + APCI3501_TIMER_STATUS_REG) & 0x1;
 	return insn->n;
 }
 
-- 
1.7.10.4


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] staging: comedi: drivers: addi-data: hwdrv_apci3501: Removed variables that is never used
  2015-01-28 21:51 [PATCH] staging: comedi: drivers: addi-data: hwdrv_apci3501: Removed variables that is never used Rickard Strandqvist
@ 2015-01-29 15:14 ` Ian Abbott
  0 siblings, 0 replies; 2+ messages in thread
From: Ian Abbott @ 2015-01-29 15:14 UTC (permalink / raw)
  To: Rickard Strandqvist, H Hartley Sweeten
  Cc: Greg Kroah-Hartman, Chase Southwood, Marcin Kostrzewa,
	Fred Akers, devel, linux-kernel

On 28/01/15 21:51, Rickard Strandqvist wrote:
> Variable ar assigned a value that is never used.
> I have also removed all the code that thereby serves no purpose.
>
> This was found using a static code analysis program called cppcheck
>
> Signed-off-by: Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
> ---
>   drivers/staging/comedi/drivers/addi-data/hwdrv_apci3501.c |    3 +--
>   1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/staging/comedi/drivers/addi-data/hwdrv_apci3501.c b/drivers/staging/comedi/drivers/addi-data/hwdrv_apci3501.c
> index 339519a..24126e3 100644
> --- a/drivers/staging/comedi/drivers/addi-data/hwdrv_apci3501.c
> +++ b/drivers/staging/comedi/drivers/addi-data/hwdrv_apci3501.c
> @@ -93,7 +93,6 @@ static int apci3501_write_insn_timer(struct comedi_device *dev,
>   {
>   	struct apci3501_private *devpriv = dev->private;
>   	unsigned int ul_Command1 = 0;
> -	int i_Temp;
>
>   	if (devpriv->b_TimerSelectMode == ADDIDATA_WATCHDOG) {
>
> @@ -135,7 +134,7 @@ static int apci3501_write_insn_timer(struct comedi_device *dev,
>   		}
>   	}
>
> -	i_Temp = inl(dev->iobase + APCI3501_TIMER_STATUS_REG) & 0x1;
> +	inl(dev->iobase + APCI3501_TIMER_STATUS_REG) & 0x1;

The ' & 0x1' part produces compiler warnings and should be removed.

I don't know if the inl() call has any side-effects or not, but since 
it's part of the watchdog functionality of this board, it's safest to 
leave it in.

>   	return insn->n;
>   }
>
>

-- 
-=( Ian Abbott @ MEV Ltd.    E-mail: <abbotti@mev.co.uk> )=-
-=(                          Web: http://www.mev.co.uk/  )=-

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2015-01-29 15:15 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-01-28 21:51 [PATCH] staging: comedi: drivers: addi-data: hwdrv_apci3501: Removed variables that is never used Rickard Strandqvist
2015-01-29 15:14 ` Ian Abbott

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).