LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Jonathan Cameron <jic23@kernel.org>
To: Karol Wrona <k.wrona@samsung.com>,
	linux-iio@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org
Cc: Hartmut Knaack <knaack.h@gmx.de>,
	Lars-Peter Clausen <lars@metafoo.de>,
	Peter Meerwald <pmeerw@pmeerw.net>,
	Rob Herring <robh+dt@kernel.org>, Pawel Moll <pawel.moll@arm.com>,
	Mark Rutland <mark.rutland@arm.com>,
	Ian Campbell <ijc+devicetree@hellion.org.uk>,
	Kumar Gala <galak@codeaurora.org>,
	Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
	Kyungmin Park <kyungmin.park@samsung.com>,
	Karol Wrona <wrona.vy@gmail.com>
Subject: Re: [PATCH v5 1/5] iio: common: ssp_sensors: Add sensorhub driver
Date: Thu, 29 Jan 2015 18:53:25 +0000	[thread overview]
Message-ID: <54CA81A5.50206@kernel.org> (raw)
In-Reply-To: <54CA8021.2020909@samsung.com>

On 29/01/15 18:46, Karol Wrona wrote:
> On 01/29/2015 07:35 PM, Jonathan Cameron wrote:
>> On 28/01/15 14:05, Karol Wrona wrote:
>>> Sensorhub  is MCU dedicated to collect data and manage several sensors.
>>> Sensorhub is a spi device which provides a layer for IIO devices. It provides
>>> some data parsing and common mechanism for sensorhub sensors.
>>>
>>> Adds common sensorhub library for sensorhub driver and iio drivers
>>> which uses sensorhub MCU to communicate with sensors.
>>>
>>> Signed-off-by: Karol Wrona <k.wrona@samsung.com>
>>> Acked-by: Kyungmin Park <kyungmin.park@samsung.com>
>> A couple of build errors from this one...
>>
>> I've fixed them up and applied to the togreg branch of iio.git.
>> Pushed out as testing.  If you get a chance to check I didn't
>> mess anything up that would be great.
>>> ---
>>>  drivers/iio/common/Kconfig               |    1 +
>>>  drivers/iio/common/Makefile              |    1 +
>>>  drivers/iio/common/ssp_sensors/Kconfig   |   26 ++
>>>  drivers/iio/common/ssp_sensors/Makefile  |    8 +
>>>  drivers/iio/common/ssp_sensors/ssp.h     |  257 +++++++++++
>>>  drivers/iio/common/ssp_sensors/ssp_dev.c |  712 ++++++++++++++++++++++++++++++
>>>  drivers/iio/common/ssp_sensors/ssp_spi.c |  608 +++++++++++++++++++++++++
>>>  include/linux/iio/common/ssp_sensors.h   |   82 ++++
>>>  8 files changed, 1695 insertions(+)
>>>  create mode 100644 drivers/iio/common/ssp_sensors/Kconfig
>>>  create mode 100644 drivers/iio/common/ssp_sensors/Makefile
>>>  create mode 100644 drivers/iio/common/ssp_sensors/ssp.h
>>>  create mode 100644 drivers/iio/common/ssp_sensors/ssp_dev.c
>>>  create mode 100644 drivers/iio/common/ssp_sensors/ssp_spi.c
>>>  create mode 100644 include/linux/iio/common/ssp_sensors.h
>>>
>>> diff --git a/drivers/iio/common/Kconfig b/drivers/iio/common/Kconfig
>>> index 0b6e97d..790f106 100644
>>> --- a/drivers/iio/common/Kconfig
>>> +++ b/drivers/iio/common/Kconfig
>>> @@ -3,4 +3,5 @@
>>>  #
>>>  
>>>  source "drivers/iio/common/hid-sensors/Kconfig"
>>> +source "drivers/iio/common/ssp_sensors/Kconfig"
>>>  source "drivers/iio/common/st_sensors/Kconfig"
>>> diff --git a/drivers/iio/common/Makefile b/drivers/iio/common/Makefile
>>> index 3112df0..b1e4d9c 100644
>>> --- a/drivers/iio/common/Makefile
>>> +++ b/drivers/iio/common/Makefile
>>> @@ -8,4 +8,5 @@
>>>  
>>>  # When adding new entries keep the list in alphabetical order
>>>  obj-y += hid-sensors/
>>> +obj-y += ssp_sensors/
>>>  obj-y += st_sensors/
>>> diff --git a/drivers/iio/common/ssp_sensors/Kconfig b/drivers/iio/common/ssp_sensors/Kconfig
>>> new file mode 100644
>>> index 0000000..0ea4faf
>>> --- /dev/null
>>> +++ b/drivers/iio/common/ssp_sensors/Kconfig
>>> @@ -0,0 +1,26 @@
>>> +#
>>> +# SSP sensor drivers and commons configuration
>>> +#
>>> +menu "SSP Sensor Common"
>>> +
>>> +config IIO_SSP_SENSORS_COMMONS
>>> +	tristate "Commons for all SSP Sensor IIO drivers"
>>> +	depends on IIO_SSP_SENSORHUB
>>> +	select IIO_BUFFER
>>> +	select IIO_KFIFO_BUF
>>> +	help
>>> +	  Say yes here to build commons for SSP sensors.
>>> +	  To compile this as a module, choose M here: the module
>>> +	  will be called ssp_iio.
>>> +
>>> +config IIO_SSP_SENSORHUB
>>> +	tristate "Samsung Sensorhub driver"
>>> +	depends on SPI
>>> +	select MFD_CORE
>>> +	help
>>> +	  SSP driver for sensorhub. +	  If you say yes here you get ssp support for sensorhub.
>>> +	  To compile this driver as a module, choose M here: the
>>> +	  module will be called sensorhub.
>>> +
>>> +endmenu
>>> diff --git a/drivers/iio/common/ssp_sensors/Makefile b/drivers/iio/common/ssp_sensors/Makefile
>>> new file mode 100644
>>> index 0000000..1e0389e
>>> --- /dev/null
>>> +++ b/drivers/iio/common/ssp_sensors/Makefile
>>> @@ -0,0 +1,8 @@
>>> +#
>>> +# Makefile for SSP sensor drivers and commons.
>>> +#
>>> +
>>> +sensorhub-objs				:= ssp_dev.o ssp_spi.o
>>> +obj-$(CONFIG_IIO_SSP_SENSORHUB)		+= sensorhub.o
>>> +
>>> +obj-$(CONFIG_IIO_SSP_SENSORS_COMMONS) 	+= ssp_iio.o
>> This file isn't in this patch.
> 
> Thanks for doing that.
> I had to mess sth up during rebase.
> 
> [...]
> 
That's fine, I just messed up moving it myself.  Forgot the Kconfig
bit needed to move patch as well.

Anyhow, hopefully the version I push in a few secs will be right!

Jonathan

  reply	other threads:[~2015-01-29 18:53 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-01-28 14:05 [PATCH v5 0/5] iio: " Karol Wrona
2015-01-28 14:05 ` [PATCH v5 1/5] iio: common: ssp_sensors: " Karol Wrona
2015-01-29 18:35   ` Jonathan Cameron
2015-01-29 18:46     ` Karol Wrona
2015-01-29 18:53       ` Jonathan Cameron [this message]
2015-01-28 14:05 ` [PATCH v5 2/5] iio: sensorhub: Add sensorhub bindings Karol Wrona
2015-01-29 18:36   ` Jonathan Cameron
2015-01-28 14:05 ` [PATCH v5 3/5] iio: common: ssp_sensors: Add sensorhub iio commons Karol Wrona
2015-01-29 18:36   ` Jonathan Cameron
2015-01-28 14:05 ` [PATCH v5 4/5] iio: common: ssp_sensors: Add sensorhub accelerometer sensor Karol Wrona
2015-01-29 18:37   ` Jonathan Cameron
2015-01-28 14:05 ` [PATCH v5 5/5] iio: common: ssp_sensors: Add sensorhub gyroscope sensor Karol Wrona
2015-01-29 18:37   ` Jonathan Cameron

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=54CA81A5.50206@kernel.org \
    --to=jic23@kernel.org \
    --cc=b.zolnierkie@samsung.com \
    --cc=devicetree@vger.kernel.org \
    --cc=galak@codeaurora.org \
    --cc=ijc+devicetree@hellion.org.uk \
    --cc=k.wrona@samsung.com \
    --cc=knaack.h@gmx.de \
    --cc=kyungmin.park@samsung.com \
    --cc=lars@metafoo.de \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=pawel.moll@arm.com \
    --cc=pmeerw@pmeerw.net \
    --cc=robh+dt@kernel.org \
    --cc=wrona.vy@gmail.com \
    --subject='Re: [PATCH v5 1/5] iio: common: ssp_sensors: Add sensorhub driver' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).