LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Tomi Valkeinen <tomi.valkeinen@ti.com>
To: Scot Doyle <lkml14@scotdoyle.com>,
	Jean-Christophe Plagniol-Villard <plagnioj@jcrosoft.com>
Cc: Geert Uytterhoeven <geert@linux-m68k.org>,
	Richard Weinberger <richard.weinberger@gmail.com>,
	<linux-fbdev@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v4 0/2] fbcon: user-defined cursor blink interval
Date: Fri, 30 Jan 2015 10:02:09 +0200	[thread overview]
Message-ID: <54CB3A81.50408@ti.com> (raw)
In-Reply-To: <alpine.DEB.2.11.1501262305150.2783@localhost.localdomain>

[-- Attachment #1: Type: text/plain, Size: 583 bytes --]

On 27/01/15 01:09, Scot Doyle wrote:
> Since users prefer different fbcon cursor blink intervals, allow the
> interval to be set via sysfs. The current interval of 200 milliseconds
> is retained as the default. Tested with intelfb.
> 
> v2:  Use kstrtos16() instead of kstrtoul() and min_t() as suggested by
>      Geert Uytterhoeven
> v3:  Add error messages as suggested by Tomi Valkeinen

When I said "return an error" I did not mean "print an error message".
You should return an error code from the show and store functions when
something went wrong.

 Tomi




[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

      parent reply	other threads:[~2015-01-30  8:02 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-01-26 23:09 Scot Doyle
2015-01-26 23:11 ` [PATCH v4 1/2] fbcon: store cursor blink interval in fbcon_ops Scot Doyle
2015-01-26 23:14 ` [PATCH v4 2/2] fbcon: expose cursor blink interval via sysfs Scot Doyle
2015-01-26 23:29 ` [PATCH v4 0/2] fbcon: user-defined cursor blink interval Richard Weinberger
2015-01-27  1:06   ` Scot Doyle
2015-01-30  8:02 ` Tomi Valkeinen [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=54CB3A81.50408@ti.com \
    --to=tomi.valkeinen@ti.com \
    --cc=geert@linux-m68k.org \
    --cc=linux-fbdev@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lkml14@scotdoyle.com \
    --cc=plagnioj@jcrosoft.com \
    --cc=richard.weinberger@gmail.com \
    --subject='Re: [PATCH v4 0/2] fbcon: user-defined cursor blink interval' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).