LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Ian Abbott <abbotti@mev.co.uk>
To: Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>,
	H Hartley Sweeten <hsweeten@visionengravers.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Chase Southwood <chase.southwood@gmail.com>,
	Marcin Kostrzewa <marckostrzewa@gmail.com>,
	Fred Akers <knivey@botops.net>,
	devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] staging: comedi: drivers: addi-data: hwdrv_apci3501: Removed variables that is never used
Date: Fri, 30 Jan 2015 10:29:22 +0000	[thread overview]
Message-ID: <54CB5D02.4030107@mev.co.uk> (raw)
In-Reply-To: <1422570648-8626-1-git-send-email-rickard_strandqvist@spectrumdigital.se>

On 29/01/15 22:30, Rickard Strandqvist wrote:
> Variable was assigned a value that was never used.
> I have also removed all the code that thereby serves no purpose.
>
> This was found using a static code analysis program called cppcheck
>
> Signed-off-by: Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
> ---
>   drivers/staging/comedi/drivers/addi-data/hwdrv_apci3501.c |    3 +--
>   1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/staging/comedi/drivers/addi-data/hwdrv_apci3501.c b/drivers/staging/comedi/drivers/addi-data/hwdrv_apci3501.c
> index 339519a..1f2f781 100644
> --- a/drivers/staging/comedi/drivers/addi-data/hwdrv_apci3501.c
> +++ b/drivers/staging/comedi/drivers/addi-data/hwdrv_apci3501.c
> @@ -93,7 +93,6 @@ static int apci3501_write_insn_timer(struct comedi_device *dev,
>   {
>   	struct apci3501_private *devpriv = dev->private;
>   	unsigned int ul_Command1 = 0;
> -	int i_Temp;
>
>   	if (devpriv->b_TimerSelectMode == ADDIDATA_WATCHDOG) {
>
> @@ -135,7 +134,7 @@ static int apci3501_write_insn_timer(struct comedi_device *dev,
>   		}
>   	}
>
> -	i_Temp = inl(dev->iobase + APCI3501_TIMER_STATUS_REG) & 0x1;
> +	inl(dev->iobase + APCI3501_TIMER_STATUS_REG);
>   	return insn->n;
>   }
>
>

Reviewed-by: Ian Abbott <abbotti@mev.co.uk>

-- 
-=( Ian Abbott @ MEV Ltd.    E-mail: <abbotti@mev.co.uk> )=-
-=(                          Web: http://www.mev.co.uk/  )=-

      reply	other threads:[~2015-01-30 10:29 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-01-29 22:30 Rickard Strandqvist
2015-01-30 10:29 ` Ian Abbott [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=54CB5D02.4030107@mev.co.uk \
    --to=abbotti@mev.co.uk \
    --cc=chase.southwood@gmail.com \
    --cc=devel@driverdev.osuosl.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=hsweeten@visionengravers.com \
    --cc=knivey@botops.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=marckostrzewa@gmail.com \
    --cc=rickard_strandqvist@spectrumdigital.se \
    --subject='Re: [PATCH v2] staging: comedi: drivers: addi-data: hwdrv_apci3501: Removed variables that is never used' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).