From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1760801AbbA3K6u (ORCPT ); Fri, 30 Jan 2015 05:58:50 -0500 Received: from devils.ext.ti.com ([198.47.26.153]:49239 "EHLO devils.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752926AbbA3K6r (ORCPT ); Fri, 30 Jan 2015 05:58:47 -0500 Message-ID: <54CB63DF.6070007@ti.com> Date: Fri, 30 Jan 2015 12:58:39 +0200 From: Roger Quadros User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.4.0 MIME-Version: 1.0 To: Tony Lindgren CC: Chanwoo Choi , Felipe Balbi , "myungjoo.ham@samsung.com" , , , devicetree , , , linux-kernel Subject: Re: [PATCH v2 1/7] extcon: usb-gpio: Introduce gpio usb extcon driver References: <1422274532-9488-1-git-send-email-rogerq@ti.com> <1422274532-9488-2-git-send-email-rogerq@ti.com> <54C66B0D.9040109@ti.com> <54C6EFC8.1090601@samsung.com> <54C7B0E5.20101@ti.com> <54C8472B.6070302@samsung.com> <54C8D238.4080001@ti.com> <20150128170954.GQ28663@atomide.com> <54CA1A12.5080507@ti.com> <20150129165625.GB16250@atomide.com> In-Reply-To: <20150129165625.GB16250@atomide.com> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 29/01/15 18:56, Tony Lindgren wrote: > * Roger Quadros [150129 03:34]: >> On 28/01/15 19:09, Tony Lindgren wrote: >>> * Roger Quadros [150128 04:15]: >>>> On 28/01/15 04:19, Chanwoo Choi wrote: >>>>>> >>>>>> I still fail to understand that we need to call disable_irq() in .suspend() and >>>>>> enable_irq() in .resume() >>>>>> >>>>>> can you point me to any other drivers doing so? >>>>> >>>>> You can refer the suspend function in drivers/mfd/max14577.c or drivers/mfd/max77693.c. >>>>> The max14577_suspend() includes the detailed comment for why using disable_irq() in suspend function. >>>>> >>>>> In max14577 case, max14577_suspend() use disable_irq() function because of i2c dependency. >>>>> If max14577 device is wake-up from suspend state before completing the resume sequence >>>>> of i2c, max14577 may fail to read/write i2c communication. >>>> >>>> Thanks for this information. I will add disable/enable_irq() in suspend/resume(). >>> >>> Are the .dts changes safe for me to apply already? >>> >> >> Yes Tony, you can pick them. Thanks. > > OK will apply the dts changes into omap-for-v3.20/dt thanks. > I have also the defconfig changes tagged, will apply those > a bit later probably as a fix after the driver is merged. Sounds good to me. Thanks Tony. cheers, -roger