LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Javier Martinez Canillas <javier.martinez@collabora.co.uk>
To: Ulf Hansson <ulf.hansson@linaro.org>
Cc: Kukjin Kim <kgene@kernel.org>,
	Doug Anderson <dianders@chromium.org>,
	Olof Johansson <olof@lixom.net>,
	Arend van Spriel <arend@broadcom.com>,
	Srinivas Kandagatla <srinivas.kandagatla@linaro.org>,
	linux-samsung-soc <linux-samsung-soc@vger.kernel.org>,
	"linux-arm-kernel@lists.infradead.org" 
	<linux-arm-kernel@lists.infradead.org>,
	linux-mmc <linux-mmc@vger.kernel.org>,
	"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v3 4/6] mmc: pwrseq_simple: Add optional reference clock support
Date: Fri, 30 Jan 2015 14:03:33 +0100	[thread overview]
Message-ID: <54CB8125.7030107@collabora.co.uk> (raw)
In-Reply-To: <CAPDyKFp5tGogzjU27jTDcHviUUwnTSgq4EP484_OprV_nPBsOg@mail.gmail.com>

Hello Ulf,

On 01/30/2015 12:17 PM, Ulf Hansson wrote:
>>  };
>> @@ -39,6 +42,11 @@ static void mmc_pwrseq_simple_pre_power_on(struct mmc_host *host)
>>         struct mmc_pwrseq_simple *pwrseq = container_of(host->pwrseq,
>>                                         struct mmc_pwrseq_simple, pwrseq);
>>
>> +       if (!IS_ERR(pwrseq->ext_clk)) {
> 
> This should be:
> 
> if (!IS_ERR(pwrseq->ext_clk) && !pwrseq->clk_enabled) {
> 
>

Oh, I thought that it was not possible to enter mmc_pwrseq_pre_power_on()
twice without a prior call to mmc_pwrseq_power_off() but I guess I didn't
read the MMC core code carefully...
 
>> +               clk_prepare_enable(pwrseq->ext_clk);
>> +               pwrseq->clk_enabled = true;
>> +       }
>> +
>>         mmc_pwrseq_simple_set_gpios_value(pwrseq, 1);
>>  }
>>
>> @@ -50,6 +58,19 @@ static void mmc_pwrseq_simple_post_power_on(struct mmc_host *host)
>>         mmc_pwrseq_simple_set_gpios_value(pwrseq, 0);
>>  }
>>
>> +static void mmc_pwrseq_simple_power_off(struct mmc_host *host)
>> +{
>> +       struct mmc_pwrseq_simple *pwrseq = container_of(host->pwrseq,
>> +                                       struct mmc_pwrseq_simple, pwrseq);
>> +
>> +       mmc_pwrseq_simple_set_gpios_value(pwrseq, 1);
>> +
>> +       if (pwrseq->clk_enabled) {
> 
> I changed this as well, but that was just to make code clearer.
> 
> if (!IS_ERR(pwrseq->ext_clk) && pwrseq->clk_enabled) {
> 
>

Yeah, if IS_ERR(pwrseq->ext_clk) then clk_enabled will always be false but I
agree that the change makes the code to be more consistent.

>>
> 
> As I stated in the response to he coverletter for the patchset, this
> patch is applied for next with above changes.
> 
> Thanks!
>

Thanks a lot for your help and for fixing these things!

> Kind regards
> Uffe
>

Best regards,
Javier


  reply	other threads:[~2015-01-30 13:03 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-01-29 15:00 [PATCH v3 0/6] Add multiple GPIO and external clock to MMC pwrseq_simple Javier Martinez Canillas
2015-01-29 15:00 ` [PATCH v3 1/6] mmc: pwrseq: Document that simple sequence support more than one GPIO Javier Martinez Canillas
2015-01-29 15:00 ` [PATCH v3 2/6] mmc: pwrseq_simple: Extend to support more pins Javier Martinez Canillas
2015-01-29 15:00 ` [PATCH v3 3/6] mmc: pwrseq: Document optional clock for the simple power sequence Javier Martinez Canillas
2015-01-29 15:00 ` [PATCH v3 4/6] mmc: pwrseq_simple: Add optional reference clock support Javier Martinez Canillas
2015-01-30 11:17   ` Ulf Hansson
2015-01-30 13:03     ` Javier Martinez Canillas [this message]
2015-01-29 15:00 ` [PATCH v3 5/6] ARM: dts: exynos5250-snow: Enable wifi power-on Javier Martinez Canillas
2015-01-29 15:00 ` [PATCH v3 6/6] ARM: dts: exynos5250-snow: Add cap-sdio-irq to wifi mmc node Javier Martinez Canillas
2015-01-30 11:13 ` [PATCH v3 0/6] Add multiple GPIO and external clock to MMC pwrseq_simple Ulf Hansson
2015-01-30 13:06   ` Javier Martinez Canillas
2015-02-04 15:06     ` Javier Martinez Canillas
2015-02-04 15:19       ` Kukjin Kim
2015-02-04 15:22         ` Javier Martinez Canillas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=54CB8125.7030107@collabora.co.uk \
    --to=javier.martinez@collabora.co.uk \
    --cc=arend@broadcom.com \
    --cc=devicetree@vger.kernel.org \
    --cc=dianders@chromium.org \
    --cc=kgene@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mmc@vger.kernel.org \
    --cc=linux-samsung-soc@vger.kernel.org \
    --cc=olof@lixom.net \
    --cc=srinivas.kandagatla@linaro.org \
    --cc=ulf.hansson@linaro.org \
    --subject='Re: [PATCH v3 4/6] mmc: pwrseq_simple: Add optional reference clock support' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).