LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: "Yun Wu (Abel)" <wuyun.wu@huawei.com>
To: Marc Zyngier <marc.zyngier@arm.com>
Cc: "tglx@linutronix.de" <tglx@linutronix.de>,
	"jason@lakedaemon.net" <jason@lakedaemon.net>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"linux-arm-kernel@lists.infradead.org" 
	<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH 5/5] irqchip: gicv3-its: add support for power down
Date: Sat, 31 Jan 2015 09:43:16 +0800	[thread overview]
Message-ID: <54CC3334.9010705@huawei.com> (raw)
In-Reply-To: <54CBDA14.3010503@arm.com>

On 2015/1/31 3:23, Marc Zyngier wrote:

> On 30/01/15 07:46, Yun Wu wrote:
>> Configurations of an ITS cannot be changed if the ITS is in an
>> active status, so it might not be safe to perform a soft reboot
>> with all the active ITSes un-disabled, etc. kexec.
>>
>> This patch will make sure all the active ITSes disabled before
>> enabling them again without resetting ITS hardware.
> 
> And what happens if the kernel crashes or gets rebooted from a watchdog?
> Or if the bootloader messes things up? The ITS is in an unknown state
> when we start again.
> 
> Wouldn't it be better to address this instead? Enforcing an safe initial
> state seems a better solution that relying on mechanisms that may not be
> relevant for all cases.
> 

Sure, checking the ITS state before initializing it is really a better
solution, I will rewrite this patch and test again.

Thanks,
	Abel


      reply	other threads:[~2015-01-31  1:43 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-01-30  7:46 [PATCH 0/5] enhance configuring an ITS Yun Wu
2015-01-30  7:46 ` [PATCH 1/5] irqchip: gicv3-its: allocate proper size for DT Yun Wu
2015-01-30 19:10   ` Marc Zyngier
2015-01-31  1:57     ` Yun Wu (Abel)
2015-01-30  7:46 ` [PATCH 2/5] irqchip: gicv3-its: zero itt before handling to hardware Yun Wu
2015-01-30 19:24   ` Marc Zyngier
2015-01-30  7:46 ` [PATCH 3/5] irqchip: gicv3-its: use 64KB page as default granule Yun Wu
2015-01-30 19:18   ` Marc Zyngier
2015-01-31  1:33     ` Yun Wu (Abel)
2015-01-30  7:46 ` [PATCH 4/5] irqchip: gicv3-its: define macros for GITS_CTLR fields Yun Wu
2015-01-30  7:46 ` [PATCH 5/5] irqchip: gicv3-its: add support for power down Yun Wu
2015-01-30 19:23   ` Marc Zyngier
2015-01-31  1:43     ` Yun Wu (Abel) [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=54CC3334.9010705@huawei.com \
    --to=wuyun.wu@huawei.com \
    --cc=jason@lakedaemon.net \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=marc.zyngier@arm.com \
    --cc=tglx@linutronix.de \
    --subject='Re: [PATCH 5/5] irqchip: gicv3-its: add support for power down' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).