From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S964827AbbBBJK1 (ORCPT ); Mon, 2 Feb 2015 04:10:27 -0500 Received: from arroyo.ext.ti.com ([192.94.94.40]:36580 "EHLO arroyo.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753468AbbBBJKW (ORCPT ); Mon, 2 Feb 2015 04:10:22 -0500 Message-ID: <54CF3EE7.2050705@ti.com> Date: Mon, 2 Feb 2015 11:09:59 +0200 From: Roger Quadros User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.4.0 MIME-Version: 1.0 To: Chanwoo Choi CC: , , , , , , , , Subject: Re: [PATCH v2 2/7] usb: extcon: Fix USB-Host cable name References: <1422274532-9488-1-git-send-email-rogerq@ti.com> <1422274532-9488-3-git-send-email-rogerq@ti.com> <54CB6539.1040703@ti.com> <54CB8FBD.6050701@ti.com> <54CF0555.4080004@samsung.com> In-Reply-To: <54CF0555.4080004@samsung.com> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Chanwoo, On 02/02/15 07:04, Chanwoo Choi wrote: > Hi Roger, > > On 01/30/2015 11:05 PM, Roger Quadros wrote: >> Hi, >> >> On 30/01/15 13:04, Roger Quadros wrote: >>> Felipe & Chanwoo, >>> >>> On 26/01/15 14:15, Roger Quadros wrote: >>>> The recommended name for USB-Host cable state is "USB-Host" and not >>>> "USB-HOST" as per drivers/extcon/extcon-class.c extcon_cable_name. >>>> >>>> Change all instances of "USB-HOST" to "USB-Host". >>>> >>>> Signed-off-by: Roger Quadros >>>> Reviewed-by: Felipe Balbi >>>> Acked-by: Felipe Balbi >>> >>> This patch has no dependency to the rest so can be picked up as soon as possible. >>> >>> Do you think it is better to go via the USB tree? >>> If yes then Chanwoo, can you please Ack this one? Thanks. >>> >>> This would mean that only the first patch needs to go through extcon tree as Tony >>> will pick the rest. >> >> Hold on. Let's first decide what we really want to go ahead with >> "USB-Host" or "USB-HOST". > > Currently, extcon driver have used the specific cable name(USB-Host or USB-HOST) > without any standard way. So, I have plan to define common cable name in extcon > header file by using capital letter. OK. In that case, this patch is not required. I will resend patch 1 with cable name corrected to "USB-HOST". cheers, -roger