LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Roger Quadros <rogerq@ti.com>
To: Chanwoo Choi <cw00.choi@samsung.com>
Cc: <balbi@ti.com>, <tony@atomide.com>, <myungjoo.ham@samsung.com>,
	<george.cherian@ti.com>, <nsekhar@ti.com>,
	<devicetree@vger.kernel.org>, <linux-usb@vger.kernel.org>,
	<linux-omap@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2 2/7] usb: extcon: Fix USB-Host cable name
Date: Mon, 2 Feb 2015 12:01:56 +0200	[thread overview]
Message-ID: <54CF4B14.4050802@ti.com> (raw)
In-Reply-To: <54CF4974.7080404@samsung.com>

On 02/02/15 11:55, Chanwoo Choi wrote:
> Hi Roger,
> 
> On 02/02/2015 06:09 PM, Roger Quadros wrote:
>> Chanwoo,
>>
>> On 02/02/15 07:04, Chanwoo Choi wrote:
>>> Hi Roger,
>>>
>>> On 01/30/2015 11:05 PM, Roger Quadros wrote:
>>>> Hi,
>>>>
>>>> On 30/01/15 13:04, Roger Quadros wrote:
>>>>> Felipe & Chanwoo,
>>>>>
>>>>> On 26/01/15 14:15, Roger Quadros wrote:
>>>>>> The recommended name for USB-Host cable state is "USB-Host" and not
>>>>>> "USB-HOST" as per drivers/extcon/extcon-class.c extcon_cable_name.
>>>>>>
>>>>>> Change all instances of "USB-HOST" to "USB-Host".
>>>>>>
>>>>>> Signed-off-by: Roger Quadros <rogerq@ti.com>
>>>>>> Reviewed-by: Felipe Balbi <balbi@ti.com>
>>>>>> Acked-by: Felipe Balbi <balbi@ti.com>
>>>>>
>>>>> This patch has no dependency to the rest so can be picked up as soon as possible.
>>>>>
>>>>> Do you think it is better to go via the USB tree?
>>>>> If yes then Chanwoo, can you please Ack this one? Thanks.
>>>>>
>>>>> This would mean that only the first patch needs to go through extcon tree as Tony
>>>>> will pick the rest.
>>>>
>>>> Hold on. Let's first decide what we really want to go ahead with
>>>> "USB-Host" or "USB-HOST".
>>>
>>> Currently, extcon driver have used the specific cable name(USB-Host or USB-HOST)
>>> without any standard way. So, I have plan to define common cable name in extcon
>>> header file by using capital letter.
>>
>> OK. In that case, this patch is not required.
>> I will resend patch 1 with cable name corrected to "USB-HOST".
> 
> If you possbile, I want to use 'USB-HOST' cable name in drivers related to extcon.
> If we use different cable name, this cause the confusion to control cable.
> 

Kernel tree shows following users of "USB-Host" that will have to be changed to
"USB-HOST".

extcon-class.c:	[EXTCON_USB_HOST]	= "USB-Host",
extcon-max77693.c:	[EXTCON_CABLE_USB_HOST]			= "USB-Host",
extcon-max77693.c:		extcon_set_cable_state(info->edev, "USB-Host", attached);
extcon-max8997.c:	[EXTCON_CABLE_USB_HOST]			= "USB-Host",
extcon-max8997.c:		extcon_set_cable_state(info->edev, "USB-Host", attached);
extcon-rt8973a.c:	[EXTCON_CABLE_USB_HOST]		= "USB-Host",
extcon-sm5502.c:	[EXTCON_CABLE_USB_HOST]	= "USB-Host",

I'm not aware if any user space programs depend on this name. Do you know of any?

cheers,
-roger

  reply	other threads:[~2015-02-02 10:02 UTC|newest]

Thread overview: 44+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-01-26 12:15 [PATCH v2 0/7] extcon: usb: Introduce USB GPIO extcon driver. Fix DRA7 & AM57xx USB Roger Quadros
2015-01-26 12:15 ` [PATCH v2 1/7] extcon: usb-gpio: Introduce gpio usb extcon driver Roger Quadros
2015-01-26 13:56   ` Chanwoo Choi
2015-01-26 16:27     ` Roger Quadros
2015-01-27  1:54       ` Chanwoo Choi
2015-01-27 15:38         ` Roger Quadros
2015-01-28  2:19           ` Chanwoo Choi
2015-01-28 12:12             ` Roger Quadros
2015-01-28 17:09               ` Tony Lindgren
2015-01-29 11:31                 ` Roger Quadros
2015-01-29 16:56                   ` Tony Lindgren
2015-01-30 10:58                     ` Roger Quadros
2015-01-28 12:15   ` [PATCH v3 " Roger Quadros
2015-01-29  1:49     ` Chanwoo Choi
2015-01-29 11:26       ` Roger Quadros
2015-01-30  0:06         ` Chanwoo Choi
2015-01-30 11:09           ` Roger Quadros
2015-01-30 13:57             ` Roger Quadros
2015-01-30  0:11     ` Chanwoo Choi
2015-01-30 14:03       ` Roger Quadros
2015-02-02  5:06         ` Chanwoo Choi
2015-02-02 10:21     ` [PATCH v4 1/1] " Roger Quadros
2015-02-03  1:13       ` Chanwoo Choi
2015-03-16 12:32       ` Ivan T. Ivanov
2015-03-16 13:11         ` Roger Quadros
2015-03-16 14:23           ` Ivan T. Ivanov
2015-03-17  2:01             ` Chanwoo Choi
2015-03-17  7:52               ` Ivan T. Ivanov
2015-03-17  8:00                 ` Ivan T. Ivanov
2015-01-26 12:15 ` [PATCH v2 2/7] usb: extcon: Fix USB-Host cable name Roger Quadros
2015-01-30 11:04   ` Roger Quadros
2015-01-30 14:05     ` Roger Quadros
2015-02-02  5:04       ` Chanwoo Choi
2015-02-02  9:09         ` Roger Quadros
2015-02-02  9:55           ` Chanwoo Choi
2015-02-02 10:01             ` Roger Quadros [this message]
2015-02-02 10:06               ` Chanwoo Choi
2015-01-26 12:15 ` [PATCH v2 3/7] ARM: dts: dra7-evm: Add extcon nodes for USB Roger Quadros
2015-01-26 12:15 ` [PATCH v2 4/7] ARM: dts: dra72-evm: " Roger Quadros
2015-01-26 12:15 ` [PATCH v2 5/7] ARM: dts: am57xx-beagle-x15: " Roger Quadros
2015-01-26 12:15 ` [PATCH v2 6/7] ARM: dts: am57xx-beagle-x15: Fix USB2 mode Roger Quadros
2015-01-26 12:15 ` [PATCH v2 7/7] ARM: omap2plus_defconfig: Enable EXTCON_GPIO_USB Roger Quadros
2015-03-16 17:53   ` Tony Lindgren
2015-03-17  9:29     ` Roger Quadros

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=54CF4B14.4050802@ti.com \
    --to=rogerq@ti.com \
    --cc=balbi@ti.com \
    --cc=cw00.choi@samsung.com \
    --cc=devicetree@vger.kernel.org \
    --cc=george.cherian@ti.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=myungjoo.ham@samsung.com \
    --cc=nsekhar@ti.com \
    --cc=tony@atomide.com \
    --subject='Re: [PATCH v2 2/7] usb: extcon: Fix USB-Host cable name' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).