From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933211AbbBBKHB (ORCPT ); Mon, 2 Feb 2015 05:07:01 -0500 Received: from mailout4.samsung.com ([203.254.224.34]:11876 "EHLO mailout4.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933079AbbBBKG6 (ORCPT ); Mon, 2 Feb 2015 05:06:58 -0500 X-AuditID: cbfee68d-f79296d000004278-d2-54cf4c3ba5df Message-id: <54CF4C3A.7070809@samsung.com> Date: Mon, 02 Feb 2015 19:06:50 +0900 From: Chanwoo Choi User-Agent: Mozilla/5.0 (X11; Linux i686; rv:17.0) Gecko/20130106 Thunderbird/17.0.2 MIME-version: 1.0 To: Roger Quadros Cc: balbi@ti.com, tony@atomide.com, myungjoo.ham@samsung.com, george.cherian@ti.com, nsekhar@ti.com, devicetree@vger.kernel.org, linux-usb@vger.kernel.org, linux-omap@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 2/7] usb: extcon: Fix USB-Host cable name References: <1422274532-9488-1-git-send-email-rogerq@ti.com> <1422274532-9488-3-git-send-email-rogerq@ti.com> <54CB6539.1040703@ti.com> <54CB8FBD.6050701@ti.com> <54CF0555.4080004@samsung.com> <54CF3EE7.2050705@ti.com> <54CF4974.7080404@samsung.com> <54CF4B14.4050802@ti.com> In-reply-to: <54CF4B14.4050802@ti.com> Content-type: text/plain; charset=windows-1252 Content-transfer-encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFlrFIsWRmVeSWpSXmKPExsWyRsSkWNfa53yIwcKrnBYH79dbzD9yjtXi 1MHlrBaXd81hs5i9pJ/FYtGyVmaL240r2Cz2925gsuh5pGWx/4qXA5fHt6+TWDz6tqxi9Dh+ YzuTx+dNcgEsUVw2Kak5mWWpRfp2CVwZZ45cYSs4I1rx5e1elgbG64JdjJwcEgImEndfPGOE sMUkLtxbzwZiCwksZZT4u8Mcpqb1+XOgOBdQfBGjxP55d5ghnNeMEg0zZjKBVPEKaEkcnbac BcRmEVCV2LPkJpjNBhTf/+IG2FRRgTCJldOvsEDUC0r8mHwPzBYRUJS4t3I92AZmgVuMEuv/ 32cHSQgLOEg8eHCMFWLbbCaJ058XgCU4BdQkvve2Am3mAOrQk7h/UQskzCwgL7F5zVuw6yQE rrFL7FoyhR3iIgGJb5MPsYDUSwjISmw6wAzxmqTEwRU3WCYwis1CctMshKmzkExdwMi8ilE0 tSC5oDgpvchQrzgxt7g0L10vOT93EyMwCk//e9a7g/H2AetDjAIcjEo8vBbvz4UIsSaWFVfm HmI0BTpiIrOUaHI+MNbzSuINjc2MLExNTI2NzC3NlMR5FaV+BgsJpCeWpGanphakFsUXleak Fh9iZOLglGpgtL7huuXUL5YJnz/UPtgorxLTmxg5R6tpx8m9Z9hf8Suemj3RcY3Wiqvn+RLm PTB95Z8/W131VUZVaW3vLonpMwPWXfoi9VtT7ahfW8DpbQePeO1In2jb7d10MeiQ24sSLp1r jwLWp9fxNG/t8bp1OW1x++EpckwX/eaxySr+F2La8e4owwbdPCWW4oxEQy3mouJEAHBUayG9 AgAA X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFvrKIsWRmVeSWpSXmKPExsVy+t9jAV1rn/MhBnfmMFocvF9vMf/IOVaL UweXs1pc3jWHzWL2kn4Wi0XLWpktbjeuYLPY37uByaLnkZbF/iteDlwe375OYvHo27KK0eP4 je1MHp83yQWwRDUw2mSkJqakFimk5iXnp2TmpdsqeQfHO8ebmhkY6hpaWpgrKeQl5qbaKrn4 BOi6ZeYAnaOkUJaYUwoUCkgsLlbSt8M0ITTETdcCpjFC1zckCK7HyAANJKxhzDhz5ApbwRnR ii9v97I0MF4X7GLk5JAQMJFoff6cDcIWk7hwbz2QzcUhJLCIUWL/vDvMEM5rRomGGTOZQKp4 BbQkjk5bzgJiswioSuxZchPMZgOK739xA2ySqECYxMrpV1gg6gUlfky+B2aLCChK3FsJsYFZ 4BajxPr/99lBEsICDhIPHhxjhdg2m0ni9OcFYAlOATWJ772tQJs5gDr0JO5f1AIJMwvIS2xe 85Z5AqPALCQ7ZiFUzUJStYCReRWjaGpBckFxUnqukV5xYm5xaV66XnJ+7iZGcJQ/k97BuKrB 4hCjAAejEg/vTYPzIUKsiWXFlbmHGCU4mJVEeDUsgEK8KYmVValF+fFFpTmpxYcYTYEhMJFZ SjQ5H5iA8kriDY1NzIwsjcwNLYyMzZXEeZXs20KEBNITS1KzU1MLUotg+pg4OKUaGEMr2NsF XA6+/2H2TDLUavHL6cvv1fzRfHdiy9djkwTNvX9wnkpv/7H4x+0DP2pP/V7936A76vpfV7kj eSfkuO3XsK+aV7m56eHfbyL92m1NNqrLJhdOLGL99emo92/7hdlvDsc5nfpZdPCzaoD4rSQ1 zlUNXlEGbFzmj5hD4z9OuVW3VuR7xn0lluKMREMt5qLiRAAX0Dz4CAMAAA== DLP-Filter: Pass X-MTR: 20000000000000000@CPGS X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 02/02/2015 07:01 PM, Roger Quadros wrote: > On 02/02/15 11:55, Chanwoo Choi wrote: >> Hi Roger, >> >> On 02/02/2015 06:09 PM, Roger Quadros wrote: >>> Chanwoo, >>> >>> On 02/02/15 07:04, Chanwoo Choi wrote: >>>> Hi Roger, >>>> >>>> On 01/30/2015 11:05 PM, Roger Quadros wrote: >>>>> Hi, >>>>> >>>>> On 30/01/15 13:04, Roger Quadros wrote: >>>>>> Felipe & Chanwoo, >>>>>> >>>>>> On 26/01/15 14:15, Roger Quadros wrote: >>>>>>> The recommended name for USB-Host cable state is "USB-Host" and not >>>>>>> "USB-HOST" as per drivers/extcon/extcon-class.c extcon_cable_name. >>>>>>> >>>>>>> Change all instances of "USB-HOST" to "USB-Host". >>>>>>> >>>>>>> Signed-off-by: Roger Quadros >>>>>>> Reviewed-by: Felipe Balbi >>>>>>> Acked-by: Felipe Balbi >>>>>> >>>>>> This patch has no dependency to the rest so can be picked up as soon as possible. >>>>>> >>>>>> Do you think it is better to go via the USB tree? >>>>>> If yes then Chanwoo, can you please Ack this one? Thanks. >>>>>> >>>>>> This would mean that only the first patch needs to go through extcon tree as Tony >>>>>> will pick the rest. >>>>> >>>>> Hold on. Let's first decide what we really want to go ahead with >>>>> "USB-Host" or "USB-HOST". >>>> >>>> Currently, extcon driver have used the specific cable name(USB-Host or USB-HOST) >>>> without any standard way. So, I have plan to define common cable name in extcon >>>> header file by using capital letter. >>> >>> OK. In that case, this patch is not required. >>> I will resend patch 1 with cable name corrected to "USB-HOST". >> >> If you possbile, I want to use 'USB-HOST' cable name in drivers related to extcon. >> If we use different cable name, this cause the confusion to control cable. >> > > Kernel tree shows following users of "USB-Host" that will have to be changed to > "USB-HOST". You're right. I'll modify all cable name of 'USB-HOST'. Also, I have plan to use only capital letter for cable name. > > extcon-class.c: [EXTCON_USB_HOST] = "USB-Host", > extcon-max77693.c: [EXTCON_CABLE_USB_HOST] = "USB-Host", > extcon-max77693.c: extcon_set_cable_state(info->edev, "USB-Host", attached); > extcon-max8997.c: [EXTCON_CABLE_USB_HOST] = "USB-Host", > extcon-max8997.c: extcon_set_cable_state(info->edev, "USB-Host", attached); > extcon-rt8973a.c: [EXTCON_CABLE_USB_HOST] = "USB-Host", > extcon-sm5502.c: [EXTCON_CABLE_USB_HOST] = "USB-Host", > > I'm not aware if any user space programs depend on this name. Do you know of any? As I knew, released samsung smart-phone used the cable name to detect the cable state becaues extcon send the uevent with both cable name and cable state. Thanks, Chanwoo Choi