LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Stephen Boyd <sboyd@codeaurora.org>
To: Alban Browaeys <alban.browaeys@gmail.com>,
	Tomeu Vizoso <tomeu.vizoso@collabora.com>,
	Mike Turquette <mturquette@linaro.org>
Cc: linux-kernel@vger.kernel.org, Alban Browaeys <prahal@yahoo.com>
Subject: Re: [PATCH 1/2] clk: Fix __clk_get access to already freed owner field.
Date: Thu, 05 Feb 2015 11:30:40 -0800	[thread overview]
Message-ID: <54D3C4E0.80608@codeaurora.org> (raw)
In-Reply-To: <1423160690-7853-1-git-send-email-prahal@yahoo.com>

On 02/05/15 10:24, Alban Browaeys wrote:
> On the second call to __set_clk_parents from of_clk_set_defaults, here
> when registering the second fimc device the kernel OOPS in an "unhandled
> paging request at virtual address 6b6b6b77". This in __clk_get when
> dereferencing clk->owner.
>
> Move the clk free in the kref managed _clk_release call instead of
> plain __clk_put.
>
> Fixes: 035a61c314eb ("clk: Make clk API return per-user struct clk
> instances)
>
> Signed-off-by: Alban Browaeys <prahal@yahoo.com>
> ---
>  drivers/clk/clk.c | 17 +++++++++--------
>  1 file changed, 9 insertions(+), 8 deletions(-)
>
> diff --git a/drivers/clk/clk.c b/drivers/clk/clk.c
> index df94668..8f33722 100644
> --- a/drivers/clk/clk.c
> +++ b/drivers/clk/clk.c
> @@ -2485,15 +2485,18 @@ EXPORT_SYMBOL_GPL(clk_register);
>   */
>  static void __clk_release(struct kref *ref)
>  {
> -	struct clk_core *clk = container_of(ref, struct clk_core, ref);
> -	int i = clk->num_parents;
> +	struct clk_core *core = container_of(ref, struct clk_core, ref);
> +	struct clk *clk = container_of(&core, struct clk, core);

How does this work? struct clk_core doesn't have a struct clk inside it.

> +	int i = core->num_parents;
>  
> -	kfree(clk->parents);
> +	kfree(core->parents);
>  	while (--i >= 0)
> -		kfree_const(clk->parent_names[i]);
> +		kfree_const(core->parent_names[i]);

We don't have kfree_const() in the clk-next tree so please resend based
on clk-next, not linux-next.

> +
> +	kfree(core->parent_names);
> +	kfree_const(core->name);
> +	kfree(core);
>  
> -	kfree(clk->parent_names);
> -	kfree_const(clk->name);
>  	kfree(clk);
>  }
>  
> @@ -2671,8 +2674,6 @@ void __clk_put(struct clk *clk)
>  	clk_prepare_unlock();
>  
>  	module_put(owner);
> -
> -	kfree(clk);
>  }
>  
>  /***        clk rate change notifiers        ***/

I'm still confused. Care to send the actual backtrace and describe which
hardware you're running on (perhaps some dts file to look at)?

-- 
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project


  parent reply	other threads:[~2015-02-05 19:30 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-02-05 18:24 Alban Browaeys
2015-02-05 18:24 ` [PATCH 2/2] clk: Fix OOPS calling hlist_del on an already poisoned hlist Alban Browaeys
2015-02-05 19:33   ` Stephen Boyd
2015-02-05 20:56     ` Alban Browaeys
2015-02-05 19:30 ` Stephen Boyd [this message]
2015-02-05 20:43   ` [PATCH 1/2] clk: Fix __clk_get access to already freed owner field Alban Browaeys
2015-02-05 21:03     ` Stephen Boyd
2015-02-05 21:30       ` Alban Browaeys
2015-02-05 21:45         ` Stephen Boyd
2015-02-06  9:52           ` Alban Browaeys

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=54D3C4E0.80608@codeaurora.org \
    --to=sboyd@codeaurora.org \
    --cc=alban.browaeys@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mturquette@linaro.org \
    --cc=prahal@yahoo.com \
    --cc=tomeu.vizoso@collabora.com \
    --subject='Re: [PATCH 1/2] clk: Fix __clk_get access to already freed owner field.' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).