LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Shuah Khan <shuahkh@osg.samsung.com>
To: John Stultz <john.stultz@linaro.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Cc: Prarit Bhargava <prarit@redhat.com>,
	Thomas Gleixner <tglx@linutronix.de>,
	Richard Cochran <richardcochran@gmail.com>
Subject: Re: [RFC][PATCH 0/7] Start adding timetests to selftest
Date: Thu, 05 Feb 2015 15:13:08 -0700	[thread overview]
Message-ID: <54D3EAF4.4030304@osg.samsung.com> (raw)
In-Reply-To: <1423118232-14096-1-git-send-email-john.stultz@linaro.org>

On 02/04/2015 11:37 PM, John Stultz wrote:
> I've maintained a suite of timekeeping and timer tests for awhile
> here: https://github.com/johnstultz-work/timetests
> 
> I've been meaning to get them reworked and submitted into the
> selftest infrastructure, but haven't had much time recently.
> 
> I'm going to have a long flight coming up so I figured I'd
> get started and get some initial feedback.
> 
> This series adds all the non-destructive tests from my
> timetests suite. The suite has more tests which actually tweak
> time state and validate things behave as expected, but I wasn't
> sure how to integrate that into the selftest infrastructure
> as I'm not sure everyone would want the tests to be mucking
> with their system time. (Currently my plan is to add a
> script similar to the runall.sh in timetests, so folks
> can go in and manually run it if they're feeling daring)

Providing a way to run destructive tests as a special
option is great. Non-destructive tests can be run in
default mode.

Thanks for the tests. Looks good to me. I am in the middle
of review at the moment, will send you comments if any.

thanks,
-- Shuah

-- 
Shuah Khan
Sr. Linux Kernel Developer
Open Source Innovation Group
Samsung Research America (Silicon Valley)
shuahkh@osg.samsung.com | (970) 217-8978

  parent reply	other threads:[~2015-02-05 22:13 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-02-05  6:37 John Stultz
2015-02-05  6:37 ` [PATCH 1/7] selftests/timers: Cleanup Makefile to make it easier to add future tests John Stultz
2015-02-05  6:39   ` John Stultz
2015-02-05  6:37 ` [PATCH 2/7] selftest/timers: Quiet warning due to lack of return check on brk John Stultz
2015-02-05  6:37 ` [PATCH 3/7] selftest/timers: Add nanosleep test from timetest suite John Stultz
2015-02-05  6:37 ` [PATCH 4/7] selftest/timers: Add inconsistency-check test from timetests John Stultz
2015-02-05  6:37 ` [PATCH 5/7] selftest/timers: Add nsleep-lat test from timetest suite John Stultz
2015-02-05  6:37 ` [PATCH 6/7] selftests/timers: Add clock skew estimation " John Stultz
2015-02-05  6:37 ` [PATCH 7/7] selftest/timers: Add set-timer-lat " John Stultz
2015-02-05 22:13 ` Shuah Khan [this message]
2015-02-05 23:27   ` [RFC][PATCH 0/7] Start adding timetests to selftest John Stultz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=54D3EAF4.4030304@osg.samsung.com \
    --to=shuahkh@osg.samsung.com \
    --cc=john.stultz@linaro.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=prarit@redhat.com \
    --cc=richardcochran@gmail.com \
    --cc=tglx@linutronix.de \
    --subject='Re: [RFC][PATCH 0/7] Start adding timetests to selftest' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).