LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Bob Liu <bob.liu@oracle.com>
To: Wei Liu <wei.liu2@citrix.com>
Cc: "Roger Pau Monné" <roger.pau@citrix.com>,
	xen-devel@lists.xen.org, david.vrabel@citrix.com,
	linux-kernel@vger.kernel.org, konrad.wilk@oracle.com,
	boris.ostrovsky@oracle.com
Subject: Re: [PATCH 2/2] drivers: xen/block: add multi-page ring support
Date: Fri, 06 Feb 2015 20:52:33 +0800	[thread overview]
Message-ID: <54D4B911.2050601@oracle.com> (raw)
In-Reply-To: <20150206110134.GC30821@zion.uk.xensource.com>


On 02/06/2015 07:01 PM, Wei Liu wrote:
> On Fri, Feb 06, 2015 at 06:47:17PM +0800, Bob Liu wrote:
>>
>> On 02/02/2015 06:43 PM, Roger Pau Monné wrote:
>>> El 23/01/15 a les 10.14, Bob Liu ha escrit:
>>>> Extend xen/block to support multi-page ring.
>>>>  * xen-blkback notify blkfront with feature-multi-ring-pages
>>>>  * xen-blkfront write to xenstore about how many pages are used as the ring
>>>>
>>>> If using 4 pages as the ring, inflight requests inscreased from 32 to 128 and
>>>> IOPS improved nearly 400% on our system.
>>>>
>>>> Signed-off-by: Bob Liu <bob.liu@oracle.com>
>>>> ---
>>>>  drivers/block/xen-blkback/xenbus.c |   86 +++++++++++++++++++++++++--------
>>>>  drivers/block/xen-blkfront.c       |   94 ++++++++++++++++++++++++++----------
>>>
>>> This requires a patch to xen/include/public/io/blkif.h in the Xen
>>> repository describing how this protocol extension is going to work
>>> before reviewing the Linux implementation.
>>>
>>
>> But there is no protocol change, just add an parameter "max_ring_pages"
>> to control how many pages can be used as the ring. Now with one page we
>> can only have 32 requests.
>>
> 
> I think Roger meant the xenbus protocol used to negotiate this feature,
> not the data protocol regarding how request and response are
> interpreted. Blkif.h (and netif.h FWIW) has section to describe xenbus
> protocol.
> 

Oh, I see. Sorry for the misunderstood.
Also will fix the indentation issue of the first patch.

Thanks,
-Bob


  reply	other threads:[~2015-02-06 12:52 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-01-23 10:14 [PATCH 1/2] xenbus_client: extend interface to suppurt multi-page ring Bob Liu
2015-01-23 10:14 ` [PATCH 2/2] drivers: xen/block: add multi-page ring support Bob Liu
2015-02-02 10:43   ` Roger Pau Monné
2015-02-06 10:47     ` Bob Liu
2015-02-06 11:01       ` Wei Liu
2015-02-06 12:52         ` Bob Liu [this message]
2015-02-05 17:41   ` [Xen-devel] " Felipe Franciosi
2015-02-06 10:43     ` Bob Liu
2015-02-06 10:57 ` [PATCH 1/2] xenbus_client: extend interface to suppurt multi-page ring Wei Liu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=54D4B911.2050601@oracle.com \
    --to=bob.liu@oracle.com \
    --cc=boris.ostrovsky@oracle.com \
    --cc=david.vrabel@citrix.com \
    --cc=konrad.wilk@oracle.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=roger.pau@citrix.com \
    --cc=wei.liu2@citrix.com \
    --cc=xen-devel@lists.xen.org \
    --subject='Re: [PATCH 2/2] drivers: xen/block: add multi-page ring support' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).