From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752485AbbBYNFt (ORCPT ); Wed, 25 Feb 2015 08:05:49 -0500 Received: from arroyo.ext.ti.com ([192.94.94.40]:38043 "EHLO arroyo.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751179AbbBYNFs (ORCPT ); Wed, 25 Feb 2015 08:05:48 -0500 Message-ID: <54EDC89D.5010707@ti.com> Date: Wed, 25 Feb 2015 15:05:33 +0200 From: Roger Quadros User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.4.0 MIME-Version: 1.0 To: Robert ABEL , CC: , , Subject: Re: [PATCH 4/8 v2] ARM OMAP2+ GPMC: fix debug output alignment References: <1424808331-17592-1-git-send-email-rabel@cit-ec.uni-bielefeld.de> <1424808331-17592-2-git-send-email-rabel@cit-ec.uni-bielefeld.de> <1424808331-17592-3-git-send-email-rabel@cit-ec.uni-bielefeld.de> <1424808331-17592-4-git-send-email-rabel@cit-ec.uni-bielefeld.de> In-Reply-To: <1424808331-17592-4-git-send-email-rabel@cit-ec.uni-bielefeld.de> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 24/02/15 22:05, Robert ABEL wrote: > GPMC debug output is aligned to 10 characters for field names. > However, some fields have bigger names, screwing up the alignment. > Consequently, alignment was changed to longest field name (17 chars) for now. > > Signed-off-by: Robert ABEL Acked-by: Roger Quadros cheers, -roger > --- > drivers/memory/omap-gpmc.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/memory/omap-gpmc.c b/drivers/memory/omap-gpmc.c > index 78b78a64..b5c8305 100644 > --- a/drivers/memory/omap-gpmc.c > +++ b/drivers/memory/omap-gpmc.c > @@ -482,7 +482,7 @@ static int set_gpmc_timing_reg(int cs, int reg, int st_bit, int end_bit, > l = gpmc_cs_read_reg(cs, reg); > #ifdef DEBUG > printk(KERN_INFO > - "GPMC CS%d: %-10s: %3d ticks, %3lu ns (was %3i ticks) %3d ns\n", > + "GPMC CS%d: %-17s: %3d ticks, %3lu ns (was %3i ticks) %3d ns\n", > cs, name, ticks, gpmc_get_fclk_period() * ticks / 1000, > (l >> st_bit) & mask, time); > #endif >