From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753082AbbBYRHI (ORCPT ); Wed, 25 Feb 2015 12:07:08 -0500 Received: from mail-wg0-f48.google.com ([74.125.82.48]:35921 "EHLO mail-wg0-f48.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752583AbbBYRHG (ORCPT ); Wed, 25 Feb 2015 12:07:06 -0500 Message-ID: <54EE0138.7020300@cit-ec.uni-bielefeld.de> Date: Wed, 25 Feb 2015 18:07:04 +0100 From: Robert Abel Reply-To: rabel@cit-ec.uni-bielefeld.de User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:31.0) Gecko/20100101 Thunderbird/31.4.0 MIME-Version: 1.0 To: Roger Quadros , linux-omap@vger.kernel.org CC: linux-kernel@vger.kernel.org, tony@atomide.com, linux@arm.linux.org.uk Subject: Re: [PATCH 8/8 v2] ARM OMAP2+ GPMC: fix WAITMONITORINGTIME divider bug References: <1424808331-17592-1-git-send-email-rabel@cit-ec.uni-bielefeld.de> <1424808331-17592-2-git-send-email-rabel@cit-ec.uni-bielefeld.de> <1424808331-17592-3-git-send-email-rabel@cit-ec.uni-bielefeld.de> <1424808331-17592-4-git-send-email-rabel@cit-ec.uni-bielefeld.de> <1424808331-17592-5-git-send-email-rabel@cit-ec.uni-bielefeld.de> <1424808331-17592-6-git-send-email-rabel@cit-ec.uni-bielefeld.de> <1424808331-17592-7-git-send-email-rabel@cit-ec.uni-bielefeld.de> <1424808331-17592-8-git-send-email-rabel@cit-ec.uni-bielefeld.de> <54EDFF20.6030103@ti.com> In-Reply-To: <54EDFF20.6030103@ti.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Roger, On 25 Feb 2015 17:58, Roger Quadros wrote: >> static unsigned int gpmc_ticks_to_ps(unsigned int ticks) >> @@ -346,16 +395,22 @@ static void gpmc_cs_bool_timings(int cs, const struct gpmc_bool_timings *p) >> * @st_bit Start Bit >> * @end_bit End Bit. Must be >= @st_bit. >> * @name DTS node name, w/o "gpmc," >> + * @cd Clock Domain of timing parameter. >> + * @shift Parameter value left shifts @shift, which is then printed instead of value. >> * @raw Raw Format Option. >> * raw format: gpmc,name = >> * tick format: gpmc,name = /‍* x ticks *‍/ >> * @noval Parameter values equal to 0 are not printed. >> - * @shift Parameter value left shifts @shift, which is then printed instead of value. >> * >> */ >> -static int get_gpmc_timing_reg(int cs, int reg, int st_bit, int end_bit, >> - bool raw, bool noval, int shift, >> - const char *name) >> +static int get_gpmc_timing_reg( >> + /* timing specifiers */ >> + int cs, int reg, int st_bit, int end_bit, >> + const char *name, const enum gpmc_clk_domain cd, >> + /* value transform */ >> + int shift, >> + /* format specifiers */ >> + bool raw, bool noval) > now that you are rearranging the parameters, "name" parameter should probably be > at the same position (or last) in get_gpmc_timing_reg() and set_gpmc_timing_reg()? > Also clock domain (cd) position could be matched if possible. I rearranged them primarily, because I wanted to group the specifiers according to function, because I found it unnatural to add clock domain to the end, when it's "more important" than the format specifiers. set_gpmc_timing_reg are fine in that regard as it doesn't have format specifiers. >> +/** >> + * set_gpmc_timing_reg - set a single timing parameter for Chip Select Region. >> + * @cs Chip Select Region. >> + * @reg GPMC_CS_CONFIGn register offset. >> + * @st_bit Start Bit >> + * @end_bit End Bit. Must be >= @st_bit. >> + * @time Timing parameter in ns. >> + * @cd Timing parameter clock domain. >> + * @name Timing parameter name. >> + * @note Caller is expected to have initialized CONFIG1 GPMCFCLKDIVIDER > @note is not a parameter. Well no, note's a note. This is a doxygen-style comment, so tools should put a note in the created documentation. Doxygen will put a box with yellow background, for instance. >> - pr_err("%s: GPMC error! CS%d: %s: %d ns, %d ticks > %d\n", >> + pr_err("%s: GPMC CS%d: %s %d ns, %d ticks > %d ticks\n", > any reason for removing the "error!" string? It's already pr_err, the "error!" in-between "GPMC CS%d" made it hard to read and there's a WARN after that statement in all cases, because a child _must_ fail if a timing parameter constraint is broken. Regards, Robert