From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753378AbbBYRVT (ORCPT ); Wed, 25 Feb 2015 12:21:19 -0500 Received: from arroyo.ext.ti.com ([192.94.94.40]:47504 "EHLO arroyo.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752644AbbBYRVR (ORCPT ); Wed, 25 Feb 2015 12:21:17 -0500 Message-ID: <54EE0468.3090000@ti.com> Date: Wed, 25 Feb 2015 19:20:40 +0200 From: Roger Quadros User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.4.0 MIME-Version: 1.0 To: Robert ABEL , CC: , , Subject: Re: [PATCH 7/8 v2] ARM OMAP2+ GPMC: calculate GPMCFCLKDIVIDER based on WAITMONITORINGTIME References: <1424808331-17592-1-git-send-email-rabel@cit-ec.uni-bielefeld.de> <1424808331-17592-2-git-send-email-rabel@cit-ec.uni-bielefeld.de> <1424808331-17592-3-git-send-email-rabel@cit-ec.uni-bielefeld.de> <1424808331-17592-4-git-send-email-rabel@cit-ec.uni-bielefeld.de> <1424808331-17592-5-git-send-email-rabel@cit-ec.uni-bielefeld.de> <1424808331-17592-6-git-send-email-rabel@cit-ec.uni-bielefeld.de> <1424808331-17592-7-git-send-email-rabel@cit-ec.uni-bielefeld.de> <54EDF969.1070902@ti.com> In-Reply-To: <54EDF969.1070902@ti.com> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Robert, On 25/02/15 18:33, Roger Quadros wrote: > On 24/02/15 22:05, Robert ABEL wrote: >> The WAITMONITORINGTIME is expressed as a number of GPMC_CLK clock cycles, >> even though the access is defined as asynchronous, and no GPMC_CLK clock >> is provided to the external device. Still, GPMCFCLKDIVIDER is used as a divider >> for the GPMC clock, so it must be programmed to define the >> correct WAITMONITORINGTIME delay. >> >> Calculate GPMCFCLKDIVIDER independent of gpmc,sync-clk-ps in DT for >> truly asynchronous accesses, i.e. both read and write asynchronous. >> >> Signed-off-by: Robert ABEL >> --- >> arch/arm/mach-omap2/gpmc-nand.c | 17 ++++----- >> arch/arm/mach-omap2/gpmc-onenand.c | 4 +-- >> drivers/memory/omap-gpmc.c | 74 ++++++++++++++++++++++++++++++++++---- >> include/linux/omap-gpmc.h | 2 +- >> 4 files changed, 80 insertions(+), 17 deletions(-) Need to patch mach-omap2/usb-tusb6010.c as well. else we get arch/arm/mach-omap2/usb-tusb6010.c: In function ‘tusb_set_async_mode’: arch/arm/mach-omap2/usb-tusb6010.c:74:2: error: too few arguments to function ‘gpmc_cs_set_timings’ In file included from arch/arm/mach-omap2/gpmc.h:14:0, from arch/arm/mach-omap2/usb-tusb6010.c:23: include/linux/omap-gpmc.h:166:12: note: declared here arch/arm/mach-omap2/usb-tusb6010.c: In function ‘tusb_set_sync_mode’: arch/arm/mach-omap2/usb-tusb6010.c:101:2: error: too few arguments to function ‘gpmc_cs_set_timings’ In file included from arch/arm/mach-omap2/gpmc.h:14:0, from arch/arm/mach-omap2/usb-tusb6010.c:23: include/linux/omap-gpmc.h:166:12: note: declared here cheers, -roger