From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753063AbbBYRWy (ORCPT ); Wed, 25 Feb 2015 12:22:54 -0500 Received: from mail-we0-f177.google.com ([74.125.82.177]:32796 "EHLO mail-we0-f177.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751963AbbBYRWw (ORCPT ); Wed, 25 Feb 2015 12:22:52 -0500 Message-ID: <54EE04EB.6000401@cit-ec.uni-bielefeld.de> Date: Wed, 25 Feb 2015 18:22:51 +0100 From: Robert Abel Reply-To: rabel@cit-ec.uni-bielefeld.de User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:31.0) Gecko/20100101 Thunderbird/31.4.0 MIME-Version: 1.0 To: Roger Quadros , linux-omap@vger.kernel.org CC: linux-kernel@vger.kernel.org, tony@atomide.com, linux@arm.linux.org.uk Subject: Re: [PATCH 8/8 v2] ARM OMAP2+ GPMC: fix WAITMONITORINGTIME divider bug References: <1424808331-17592-1-git-send-email-rabel@cit-ec.uni-bielefeld.de> <1424808331-17592-2-git-send-email-rabel@cit-ec.uni-bielefeld.de> <1424808331-17592-3-git-send-email-rabel@cit-ec.uni-bielefeld.de> <1424808331-17592-4-git-send-email-rabel@cit-ec.uni-bielefeld.de> <1424808331-17592-5-git-send-email-rabel@cit-ec.uni-bielefeld.de> <1424808331-17592-6-git-send-email-rabel@cit-ec.uni-bielefeld.de> <1424808331-17592-7-git-send-email-rabel@cit-ec.uni-bielefeld.de> <1424808331-17592-8-git-send-email-rabel@cit-ec.uni-bielefeld.de> <54EDFF20.6030103@ti.com> <54EE0138.7020300@cit-ec.uni-bielefeld.de> <54EE03C5.2090306@ti.com> In-Reply-To: <54EE03C5.2090306@ti.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Roger, On 25 Feb 2015 18:17, Roger Quadros wrote: > How will the user know by looking at the kernel log that it was really an error? > We don't fail probe if set_gpmc_timing_reg() fails so I feel it is necessary to > clearly show an Error message. > > You can probably reword it like "%s: Error!! GPMC CS %d..." I'll put "error" in there. But just for the record, it's this messaged followed by a WARN that explains "failed to add child %s". So I'd expect the user to put A and B together ;) Robert