LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Javier Martinez Canillas <javier.martinez@collabora.co.uk>
To: Addy Ke <addy.ke@rock-chips.com>,
ulf.hansson@linaro.org, jh80.chung@samsung.com, olof@lixom.net,
heiko@sntech.de
Cc: huangtao@rock-chips.com, lintao@rock-chips.com,
cf@rock-chips.com, linux-rockchip@lists.infradead.org,
linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2] mmc: dw_mmc: fix bug that cause mmc_test failture
Date: Wed, 25 Feb 2015 19:17:53 +0100 [thread overview]
Message-ID: <54EE11D1.7050608@collabora.co.uk> (raw)
In-Reply-To: <1424400925-3867-1-git-send-email-addy.ke@rock-chips.com>
Hello Addy,
On 02/20/2015 03:55 AM, Addy Ke wrote:
> The STOP command can terminate a data transfer between a memory card and
> mmc controller.
>
> As show in Synopsys DesignWare Cores Mobile Stroage Host Databook:
s/Stroage/Storage but maybe Ulf can amend the typo when applying?
> Data timeout and Data end-bit error will terminate further data transfer
> by mmc controller. So we should not send abort command to terminate a
> data transfer again if we got DRTO and EBE interrupt.
>
> After this patch, all mmc_test cases can pass on RK3288-Pink2 board.
>
> Signed-off-by: Addy Ke <addy.ke@rock-chips.com>
I did not run all the tests listed in /sys/kernel/debug/mmc*/*/testlist
because some of them will overwrite the data in my card but at least
the read ones completed successfully and $subject does not cause a
regression in the Exynos5250 Snow, Exynos5420 Peach Pit and Exynos5800
Peach Pi Chromebooks where I tested it.
Tested-by: Javier Martinez Canillas <javier.martinez@collabora.co.uk>
Best regards,
Javier
next prev parent reply other threads:[~2015-02-25 18:18 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-26 12:04 [PATCH] " Addy Ke
2015-02-10 9:34 ` Olof Johansson
2015-02-11 3:03 ` Addy
2015-02-19 22:39 ` Doug Anderson
2015-02-20 2:55 ` [PATCH v2] " Addy Ke
2015-02-20 21:43 ` Doug Anderson
2015-02-25 18:17 ` Javier Martinez Canillas [this message]
2015-02-27 7:11 ` Jaehoon Chung
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54EE11D1.7050608@collabora.co.uk \
--to=javier.martinez@collabora.co.uk \
--cc=addy.ke@rock-chips.com \
--cc=cf@rock-chips.com \
--cc=heiko@sntech.de \
--cc=huangtao@rock-chips.com \
--cc=jh80.chung@samsung.com \
--cc=lintao@rock-chips.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=olof@lixom.net \
--cc=ulf.hansson@linaro.org \
--subject='Re: [PATCH v2] mmc: dw_mmc: fix bug that cause mmc_test failture' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).