LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Tadeusz Struk <tadeusz.struk@intel.com>
To: Stephan Mueller <smueller@chronox.de>,
	Herbert Xu <herbert@gondor.apana.org.au>
Cc: "'Quentin Gouchet'" <quentin.gouchet@gmail.com>,
	Daniel Borkmann <dborkman@redhat.com>,
	"'LKML'" <linux-kernel@vger.kernel.org>,
	linux-crypto@vger.kernel.org,
	"'Linux API'" <linux-api@vger.kernel.org>
Subject: Re: [PATCH v12 1/2] crypto: AF_ALG: add AEAD support
Date: Fri, 27 Feb 2015 10:34:37 -0800	[thread overview]
Message-ID: <54F0B8BD.30600@intel.com> (raw)
In-Reply-To: <2021530.t7zNty0mPn@tauon>

On 02/27/2015 02:26 AM, Stephan Mueller wrote:
>>>> This patch adds the AEAD support for AF_ALG.
>>>> >> > 
>>>> >> > The implementation is based on algif_skcipher, but contains heavy
>>>> >> > modifications to streamline the interface for AEAD uses.
>>>> >> > 
>>>> >> > To use AEAD, the user space consumer has to use the salg_type named
>>>> >> > "aead".
>>> >> 
>>> >> I just saw Al Viro's patch to use the iov_iter API in
>>> >> algif_skcipher.c. I looked at it but lacked documentation for using
>>> >> it properly. Now I have a template that I will incorporate into
>>> >> algif_aead.c
>> >
>> >Please resubmit once you have done this.
> I have done that, but as indicated with an email to Al, I cannot get his 
> patch for skcipher and hash to work. Similarly, my modification for the 
> AEAD does not work either. So, I do not see that Al's patch can be 
> merged as is.
> 
> Therefore, I have not submitted my patch as Al mentioned he wanted to 
> look into his patchset.

Hi Stephan,
There was a problem with the iov_iter changes, but it has been fixed on netdev during merging window.
The algif_skcipher works fine for me on the latest (4.0.0-rc1+) cryptodev.

Regards,
Tadeusz

  reply	other threads:[~2015-02-27 18:38 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-01-29 20:23 [PATCH v12 0/2] crypto: AF_ALG: add AEAD and RNG support Stephan Mueller
2015-01-29 20:24 ` [PATCH v12 1/2] crypto: AF_ALG: add AEAD support Stephan Mueller
2015-02-05 15:10   ` Stephan Mueller
2015-02-27  9:49     ` Herbert Xu
2015-02-27 10:26       ` Stephan Mueller
2015-02-27 18:34         ` Tadeusz Struk [this message]
2015-02-27 18:54           ` Stephan Mueller
2015-01-29 20:26 ` [PATCH v12 2/2] crypto: AF_ALG: enable AEAD interface compilation Stephan Mueller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=54F0B8BD.30600@intel.com \
    --to=tadeusz.struk@intel.com \
    --cc=dborkman@redhat.com \
    --cc=herbert@gondor.apana.org.au \
    --cc=linux-api@vger.kernel.org \
    --cc=linux-crypto@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=quentin.gouchet@gmail.com \
    --cc=smueller@chronox.de \
    --subject='Re: [PATCH v12 1/2] crypto: AF_ALG: add AEAD support' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).