From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754959AbbB0Si1 (ORCPT ); Fri, 27 Feb 2015 13:38:27 -0500 Received: from mga01.intel.com ([192.55.52.88]:65391 "EHLO mga01.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752158AbbB0SiZ (ORCPT ); Fri, 27 Feb 2015 13:38:25 -0500 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.09,661,1418112000"; d="scan'208";a="460376625" Message-ID: <54F0B8BD.30600@intel.com> Date: Fri, 27 Feb 2015 10:34:37 -0800 From: Tadeusz Struk User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.5.0 MIME-Version: 1.0 To: Stephan Mueller , Herbert Xu CC: "'Quentin Gouchet'" , Daniel Borkmann , "'LKML'" , linux-crypto@vger.kernel.org, "'Linux API'" Subject: Re: [PATCH v12 1/2] crypto: AF_ALG: add AEAD support References: <1681008.mocmysOoQU@tachyon.chronox.de> <7821728.KTX1G67VgF@tachyon.chronox.de> <20150227094944.GA29071@gondor.apana.org.au> <2021530.t7zNty0mPn@tauon> In-Reply-To: <2021530.t7zNty0mPn@tauon> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 02/27/2015 02:26 AM, Stephan Mueller wrote: >>>> This patch adds the AEAD support for AF_ALG. >>>> >> > >>>> >> > The implementation is based on algif_skcipher, but contains heavy >>>> >> > modifications to streamline the interface for AEAD uses. >>>> >> > >>>> >> > To use AEAD, the user space consumer has to use the salg_type named >>>> >> > "aead". >>> >> >>> >> I just saw Al Viro's patch to use the iov_iter API in >>> >> algif_skcipher.c. I looked at it but lacked documentation for using >>> >> it properly. Now I have a template that I will incorporate into >>> >> algif_aead.c >> > >> >Please resubmit once you have done this. > I have done that, but as indicated with an email to Al, I cannot get his > patch for skcipher and hash to work. Similarly, my modification for the > AEAD does not work either. So, I do not see that Al's patch can be > merged as is. > > Therefore, I have not submitted my patch as Al mentioned he wanted to > look into his patchset. Hi Stephan, There was a problem with the iov_iter changes, but it has been fixed on netdev during merging window. The algif_skcipher works fine for me on the latest (4.0.0-rc1+) cryptodev. Regards, Tadeusz