LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
* [PATCH block/for-4.0-fixes] writeback: add missing INITIAL_JIFFIES init in global_update_bandwidth()
@ 2015-03-04 15:22 Tejun Heo
  2015-03-04 15:30 ` Jan Kara
  0 siblings, 1 reply; 5+ messages in thread
From: Tejun Heo @ 2015-03-04 15:22 UTC (permalink / raw)
  To: Jens Axboe; +Cc: Wu Fengguang, Jan Kara, linux-kernel, linux-mm, linux-fsdevel

global_update_bandwidth() uses static variable update_time as the
timestamp for the last update but forgets to initialize it to
INITIALIZE_JIFFIES.

This means that global_dirty_limit will be 5 mins into the future on
32bit and some large amount jiffies into the past on 64bit.  This
isn't critical as the only effect is that global_dirty_limit won't be
updated for the first 5 mins after booting on 32bit machines,
especially given the auxiliary nature of global_dirty_limit's role -
protecting against global dirty threshold's sudden dips; however, it
does lead to unintended suboptimal behavior.  Fix it.

Signed-off-by: Tejun Heo <tj@kernel.org>
Cc: Wu Fengguang <fengguang.wu@intel.com>
Cc: Jan Kara <jack@suse.cz>
Cc: Jens Axboe <axboe@kernel.dk>
Cc: stable@vger.kernel.org
---
 mm/page-writeback.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

--- a/mm/page-writeback.c
+++ b/mm/page-writeback.c
@@ -922,7 +922,7 @@ static void global_update_bandwidth(unsi
 				    unsigned long now)
 {
 	static DEFINE_SPINLOCK(dirty_lock);
-	static unsigned long update_time;
+	static unsigned long update_time = INITIAL_JIFFIES;
 
 	/*
 	 * check locklessly first to optimize away locking for the most time

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH block/for-4.0-fixes] writeback: add missing INITIAL_JIFFIES init in global_update_bandwidth()
  2015-03-04 15:22 [PATCH block/for-4.0-fixes] writeback: add missing INITIAL_JIFFIES init in global_update_bandwidth() Tejun Heo
@ 2015-03-04 15:30 ` Jan Kara
  2015-03-04 15:31   ` Jens Axboe
  0 siblings, 1 reply; 5+ messages in thread
From: Jan Kara @ 2015-03-04 15:30 UTC (permalink / raw)
  To: Tejun Heo
  Cc: Jens Axboe, Wu Fengguang, Jan Kara, linux-kernel, linux-mm,
	linux-fsdevel

On Wed 04-03-15 10:22:43, Tejun Heo wrote:
> global_update_bandwidth() uses static variable update_time as the
> timestamp for the last update but forgets to initialize it to
> INITIALIZE_JIFFIES.
> 
> This means that global_dirty_limit will be 5 mins into the future on
> 32bit and some large amount jiffies into the past on 64bit.  This
> isn't critical as the only effect is that global_dirty_limit won't be
> updated for the first 5 mins after booting on 32bit machines,
> especially given the auxiliary nature of global_dirty_limit's role -
> protecting against global dirty threshold's sudden dips; however, it
> does lead to unintended suboptimal behavior.  Fix it.
  Looks good. You can add:
Reviewed-by: Jan Kara <jack@suse.cz>

								Honza

> 
> Signed-off-by: Tejun Heo <tj@kernel.org>
> Cc: Wu Fengguang <fengguang.wu@intel.com>
> Cc: Jan Kara <jack@suse.cz>
> Cc: Jens Axboe <axboe@kernel.dk>
> Cc: stable@vger.kernel.org
> ---
>  mm/page-writeback.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> --- a/mm/page-writeback.c
> +++ b/mm/page-writeback.c
> @@ -922,7 +922,7 @@ static void global_update_bandwidth(unsi
>  				    unsigned long now)
>  {
>  	static DEFINE_SPINLOCK(dirty_lock);
> -	static unsigned long update_time;
> +	static unsigned long update_time = INITIAL_JIFFIES;
>  
>  	/*
>  	 * check locklessly first to optimize away locking for the most time
-- 
Jan Kara <jack@suse.cz>
SUSE Labs, CR

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH block/for-4.0-fixes] writeback: add missing INITIAL_JIFFIES init in global_update_bandwidth()
  2015-03-04 15:30 ` Jan Kara
@ 2015-03-04 15:31   ` Jens Axboe
  2015-03-04 15:37     ` Tejun Heo
  0 siblings, 1 reply; 5+ messages in thread
From: Jens Axboe @ 2015-03-04 15:31 UTC (permalink / raw)
  To: Jan Kara, Tejun Heo; +Cc: Wu Fengguang, linux-kernel, linux-mm, linux-fsdevel

On 03/04/2015 08:30 AM, Jan Kara wrote:
> On Wed 04-03-15 10:22:43, Tejun Heo wrote:
>> global_update_bandwidth() uses static variable update_time as the
>> timestamp for the last update but forgets to initialize it to
>> INITIALIZE_JIFFIES.
>>
>> This means that global_dirty_limit will be 5 mins into the future on
>> 32bit and some large amount jiffies into the past on 64bit.  This
>> isn't critical as the only effect is that global_dirty_limit won't be
>> updated for the first 5 mins after booting on 32bit machines,
>> especially given the auxiliary nature of global_dirty_limit's role -
>> protecting against global dirty threshold's sudden dips; however, it
>> does lead to unintended suboptimal behavior.  Fix it.
>    Looks good. You can add:
> Reviewed-by: Jan Kara <jack@suse.cz>

We should add that it fixes c42843f2f0bbc (from 2011!) as well.

-- 
Jens Axboe


^ permalink raw reply	[flat|nested] 5+ messages in thread

* [PATCH block/for-4.0-fixes] writeback: add missing INITIAL_JIFFIES init in global_update_bandwidth()
  2015-03-04 15:31   ` Jens Axboe
@ 2015-03-04 15:37     ` Tejun Heo
  2015-03-04 15:38       ` Jens Axboe
  0 siblings, 1 reply; 5+ messages in thread
From: Tejun Heo @ 2015-03-04 15:37 UTC (permalink / raw)
  To: Jens Axboe; +Cc: Jan Kara, Wu Fengguang, linux-kernel, linux-mm, linux-fsdevel

Subject: writeback: add missing INITIAL_JIFFIES init in global_update_bandwidth()

global_update_bandwidth() uses static variable update_time as the
timestamp for the last update but forgets to initialize it to
INITIALIZE_JIFFIES.

This means that global_dirty_limit will be 5 mins into the future on
32bit and some large amount jiffies into the past on 64bit.  This
isn't critical as the only effect is that global_dirty_limit won't be
updated for the first 5 mins after booting on 32bit machines,
especially given the auxiliary nature of global_dirty_limit's role -
protecting against global dirty threshold's sudden dips; however, it
does lead to unintended suboptimal behavior.  Fix it.

Fixes: c42843f2f0bb ("writeback: introduce smoothed global dirty limit")
Signed-off-by: Tejun Heo <tj@kernel.org>
Acked-by: Jan Kara <jack@suse.cz>
Cc: Wu Fengguang <fengguang.wu@intel.com>
Cc: Jens Axboe <axboe@kernel.dk>
Cc: stable@vger.kernel.org
---
Added the "fixes" tag.  Jens, can you please route this one?

Thanks.

 mm/page-writeback.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

--- a/mm/page-writeback.c
+++ b/mm/page-writeback.c
@@ -922,7 +922,7 @@ static void global_update_bandwidth(unsi
 				    unsigned long now)
 {
 	static DEFINE_SPINLOCK(dirty_lock);
-	static unsigned long update_time;
+	static unsigned long update_time = INITIAL_JIFFIES;
 
 	/*
 	 * check locklessly first to optimize away locking for the most time

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH block/for-4.0-fixes] writeback: add missing INITIAL_JIFFIES init in global_update_bandwidth()
  2015-03-04 15:37     ` Tejun Heo
@ 2015-03-04 15:38       ` Jens Axboe
  0 siblings, 0 replies; 5+ messages in thread
From: Jens Axboe @ 2015-03-04 15:38 UTC (permalink / raw)
  To: Tejun Heo; +Cc: Jan Kara, Wu Fengguang, linux-kernel, linux-mm, linux-fsdevel

On 03/04/2015 08:37 AM, Tejun Heo wrote:
> Subject: writeback: add missing INITIAL_JIFFIES init in global_update_bandwidth()
>
> global_update_bandwidth() uses static variable update_time as the
> timestamp for the last update but forgets to initialize it to
> INITIALIZE_JIFFIES.
>
> This means that global_dirty_limit will be 5 mins into the future on
> 32bit and some large amount jiffies into the past on 64bit.  This
> isn't critical as the only effect is that global_dirty_limit won't be
> updated for the first 5 mins after booting on 32bit machines,
> especially given the auxiliary nature of global_dirty_limit's role -
> protecting against global dirty threshold's sudden dips; however, it
> does lead to unintended suboptimal behavior.  Fix it.
>
> Fixes: c42843f2f0bb ("writeback: introduce smoothed global dirty limit")
> Signed-off-by: Tejun Heo <tj@kernel.org>
> Acked-by: Jan Kara <jack@suse.cz>
> Cc: Wu Fengguang <fengguang.wu@intel.com>
> Cc: Jens Axboe <axboe@kernel.dk>
> Cc: stable@vger.kernel.org
> ---
> Added the "fixes" tag.  Jens, can you please route this one?

Yup will do, thanks Tejun.

-- 
Jens Axboe


^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2015-03-04 15:39 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-03-04 15:22 [PATCH block/for-4.0-fixes] writeback: add missing INITIAL_JIFFIES init in global_update_bandwidth() Tejun Heo
2015-03-04 15:30 ` Jan Kara
2015-03-04 15:31   ` Jens Axboe
2015-03-04 15:37     ` Tejun Heo
2015-03-04 15:38       ` Jens Axboe

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).