LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Stephen Boyd <sboyd@codeaurora.org>
To: "Ivan T. Ivanov" <iivanov@mm-sol.com>,
	Rob Herring <robh+dt@kernel.org>, Pawel Moll <pawel.moll@arm.com>,
	Mark Rutland <mark.rutland@arm.com>,
	Ian Campbell <ijc+devicetree@hellion.org.uk>,
	Kumar Gala <galak@codeaurora.org>,
	Lee Jones <lee.jones@linaro.org>
Cc: Samuel Ortiz <sameo@linux.intel.com>,
	Stanimir Varbanov <svarbanov@mm-sol.com>,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-arm-msm@vger.kernel.org
Subject: Re: [PATCH v2] mfd: Add specific compatible strings for Qualcomm's SPMI PMIC's
Date: Wed, 04 Mar 2015 11:05:16 -0800	[thread overview]
Message-ID: <54F7576C.9060808@codeaurora.org> (raw)
In-Reply-To: <1425464365-3291-1-git-send-email-iivanov@mm-sol.com>

On 03/04/15 02:19, Ivan T. Ivanov wrote:
> +
> +static const struct of_device_id pmic_spmi_id_table[] = {
> +	[COMMON_SUBTYPE]  = { .compatible = "qcom,spmi-pmic" },
> +	[PM8941_SUBTYPE]  = { .compatible = "qcom,pm8941" },
> +	[PM8841_SUBTYPE]  = { .compatible = "qcom,pm8841" },
> +	[PM8019_SUBTYPE]  = { .compatible = "qcom,pm8019" },
> +	[PM8226_SUBTYPE]  = { .compatible = "qcom,pm8226" },
> +	[PM8110_SUBTYPE]  = { .compatible = "qcom,pm8110" },
> +	[PMA8084_SUBTYPE] = { .compatible = "qcom,pma8084" },
> +	[PMI8962_SUBTYPE] = { .compatible = "qcom,pmi8962" },
> +	[PMD9635_SUBTYPE] = { .compatible = "qcom,pmd9635" },
> +	[PM8994_SUBTYPE]  = { .compatible = "qcom,pm8994" },
> +	[PMI8994_SUBTYPE] = { .compatible = "qcom,pmi8994" },
> +	[PM8916_SUBTYPE]  = { .compatible = "qcom,pm8916" },
> +	[PM8004_SUBTYPE]  = { .compatible = "qcom,pm8004" },
> +	[PM8909_SUBTYPE]  = { .compatible = "qcom,pm8909" },
> +	{ }
> +};

Also this seems error prone in the case where we may have skips between
pmic model numbers and then the of_device_id table is going to have a
sentinel in the middle of the table. It's probably better to store the
subtype number in the data field and iterate over the array.

-- 
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project


  parent reply	other threads:[~2015-03-04 19:05 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-03-04 10:19 Ivan T. Ivanov
2015-03-04 19:01 ` Stephen Boyd
2015-03-05  8:14   ` Ivan T. Ivanov
2015-03-04 19:05 ` Stephen Boyd [this message]
2015-03-05  8:16   ` Ivan T. Ivanov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=54F7576C.9060808@codeaurora.org \
    --to=sboyd@codeaurora.org \
    --cc=devicetree@vger.kernel.org \
    --cc=galak@codeaurora.org \
    --cc=iivanov@mm-sol.com \
    --cc=ijc+devicetree@hellion.org.uk \
    --cc=lee.jones@linaro.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=pawel.moll@arm.com \
    --cc=robh+dt@kernel.org \
    --cc=sameo@linux.intel.com \
    --cc=svarbanov@mm-sol.com \
    --subject='Re: [PATCH v2] mfd: Add specific compatible strings for Qualcomm'\''s SPMI PMIC'\''s' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).