From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932706AbbCEL1t (ORCPT ); Thu, 5 Mar 2015 06:27:49 -0500 Received: from mail-wg0-f52.google.com ([74.125.82.52]:33767 "EHLO mail-wg0-f52.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932491AbbCEL1r (ORCPT ); Thu, 5 Mar 2015 06:27:47 -0500 Message-ID: <54F83DAE.2060607@redhat.com> Date: Thu, 05 Mar 2015 12:27:42 +0100 From: Paolo Bonzini User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.5.0 MIME-Version: 1.0 To: Marc Zyngier , Eric Auger , "eric.auger@st.com" , "christoffer.dall@linaro.org" , "linux-arm-kernel@lists.infradead.org" , "kvmarm@lists.cs.columbia.edu" , "kvm@vger.kernel.org" CC: Andre Przywara , "linux-kernel@vger.kernel.org" , "patches@linaro.org" , "gleb@kernel.org" Subject: Re: [PATCH v9 5/5] KVM: arm/arm64: add irqfd support References: <1425464076-20558-1-git-send-email-eric.auger@linaro.org> <1425464076-20558-6-git-send-email-eric.auger@linaro.org> <54F8359A.4020405@arm.com> In-Reply-To: <54F8359A.4020405@arm.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 05/03/2015 11:53, Marc Zyngier wrote: > > +#ifdef CONFIG_HAVE_KVM_IRQFD > > + case KVM_CAP_IRQFD: > > + r = vgic_present; > > + break; > > +#endif > > Nitpick: we have "select HAVE_KVM_IRQFD", so we can lose the #ifdef-ery. Alternatively, I've just posted a patch to move the KVM_CAP_IRQFD case to common code. vgic_present probably should be replaced by IS_ENABLED(CONFIG_KVM_ARM_VGIC). I've sent a patch for this. Paolo