LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Ingo Flaschberger <ingo.flaschberger@gmail.com>
To: Markus Pargmann <mpa@pengutronix.de>
Cc: linux-kernel@vger.kernel.org
Subject: Re: Fwd: Re: unbind/bind w1-gpio with device tree produce a crash
Date: Thu, 05 Mar 2015 12:56:11 +0100	[thread overview]
Message-ID: <54F8445B.10805@gmail.com> (raw)
In-Reply-To: <20150305073524.GC8062@pengutronix.de>

Dear Markus,

Am 05.03.2015 um 08:35 schrieb Markus Pargmann:
> Good point. The easy way to solve this may be to check in the remove
> function if the devicetree node for this device is available. If it is,
> we know that platform_data was allocated with devm_* and we can set
> platform_data to NULL.
>
> I think the better solution would be to create a private structure with
> the same data as w1_gpio_platform_data. It may even use the same struct.
> But it should not be stored in platform_data. Instead it should be
> handled seperately. For DT we can allocate it using devm_kzalloc(). And
> for probing with pdata, this could just be the pointer to the pdata
> within the device struct.
>
>


Could you give me more details about the "private structure" idea, 
perhaps off-list?

The  backup method via w1_gpio_*_orig collides when more than 1 bus is 
used, this data could be stored in the private structure too.

Kind regards,
     Ingo Flaschberger


  reply	other threads:[~2015-03-05 11:54 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-03-04  3:53 Ingo Flaschberger
2015-03-04 16:38 ` Ingo Flaschberger
     [not found]   ` <54F7C5D4.3000604@gmail.com>
2015-03-05  7:35     ` Fwd: " Markus Pargmann
2015-03-05 11:56       ` Ingo Flaschberger [this message]
2015-03-09 10:18         ` [PATCH] w1: gpio: Fix problematic platform_data usage Markus Pargmann
2015-04-10 10:22           ` Markus Pargmann
2016-03-22 11:59             ` Ingo Flaschberger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=54F8445B.10805@gmail.com \
    --to=ingo.flaschberger@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mpa@pengutronix.de \
    --subject='Re: Fwd: Re: unbind/bind w1-gpio with device tree produce a crash' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).