From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755628AbbCEMY2 (ORCPT ); Thu, 5 Mar 2015 07:24:28 -0500 Received: from mail-qa0-f44.google.com ([209.85.216.44]:33412 "EHLO mail-qa0-f44.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755605AbbCEMYZ (ORCPT ); Thu, 5 Mar 2015 07:24:25 -0500 Message-ID: <54F84AF6.7060705@hurleysoftware.com> Date: Thu, 05 Mar 2015 07:24:22 -0500 From: Peter Hurley User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.5.0 MIME-Version: 1.0 To: Geert Uytterhoeven CC: Greg Kroah-Hartman , Grant Likely , Rob Herring , "linux-serial@vger.kernel.org" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH -next 07/12] serial: earlycon: Common log banner for command line and DT References: <1425489871-22415-1-git-send-email-peter@hurleysoftware.com> <1425489871-22415-8-git-send-email-peter@hurleysoftware.com> In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Geert, On 03/05/2015 07:02 AM, Geert Uytterhoeven wrote: > Hi Peter, > > On Wed, Mar 4, 2015 at 6:24 PM, Peter Hurley wrote: >> --- a/drivers/tty/serial/earlycon.c >> +++ b/drivers/tty/serial/earlycon.c >> @@ -69,6 +69,7 @@ static void __init earlycon_init(struct earlycon_device *device, >> const char *name) >> { >> struct console *earlycon = device->con; >> + struct uart_port *port = &device->port; >> const char *s; >> size_t len; >> >> @@ -82,6 +83,16 @@ static void __init earlycon_init(struct earlycon_device *device, >> len = s - name; >> strlcpy(earlycon->name, name, min(len + 1, sizeof(earlycon->name))); >> earlycon->data = &early_console_dev; >> + >> + if (port->iotype == UPIO_MEM || port->iotype == UPIO_MEM32) >> + pr_info("Early serial console at MMIO%s 0x%llx (options '%s')\n", >> + (port->iotype == UPIO_MEM32) ? "32" : "", >> + (unsigned long long)port->mapbase, > > I know you're just moving this piece of code around, but mapbase is a > resource_size_t (it should actually be phys_addr_t, which probably didn't > exist in 2007), so it should be printed using %pa and passing a reference, > instead of %llx and using a cast. Good point. I could add that fix to the 8/12 patch which adds the earlycon name to the banner. I have to respin anyway because of a rebase error that breaks x86 build. Regards, Peter Hurley