LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Rik van Riel <riel@redhat.com>
To: Frederic Weisbecker <fweisbec@gmail.com>,
	LKML <linux-kernel@vger.kernel.org>
Cc: Paolo Bonzini <pbonzini@redhat.com>,
	Alexander Graf <agraf@suse.de>,
	Luiz Capitulino <lcapitulino@redhat.com>,
	Christian Borntraeger <borntraeger@de.ibm.com>,
	Benjamin Herrenschmidt <benh@kernel.crashing.org>,
	Marcelo Tosatti <mtosatti@redhat.com>,
	"Paul E . McKenney" <paulmck@linux.vnet.ibm.com>,
	Andy Lutomirski <luto@amacapital.net>,
	Will deacon <will.deacon@arm.com>
Subject: Re: [PATCH 2/7] context_tracking: Rename context symbols to prepare for transition state
Date: Thu, 05 Mar 2015 11:07:16 -0500	[thread overview]
Message-ID: <54F87F34.80408@redhat.com> (raw)
In-Reply-To: <1425521696-4471-3-git-send-email-fweisbec@gmail.com>

On 03/04/2015 09:14 PM, Frederic Weisbecker wrote:
> Current context tracking symbols are designed to express living state.
> As such they are prefixed with "IN_": IN_USER, IN_KERNEL.
> 
> Now we are going to use these symbols to also express state transitions
> such as context_tracking_enter(IN_USER) or context_tracking_exit(IN_USER).
> But while the "IN_" prefix works well to express entering a context, it's
> confusing to depict a context exit: context_tracking_exit(IN_USER)
> could mean two things:
> 	1) We are exiting the current context to enter user context.
> 	2) We are exiting the user context
> We want 2) but the reviewer may be confused and understand 1)
> 
> So lets disambiguate these symbols and rename them to CONTEXT_USER and
> CONTEXT_KERNEL.
> 
> Cc: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
> Cc: Andy Lutomirski <luto@amacapital.net>
> Cc: Will deacon <will.deacon@arm.com>
> Cc: Marcelo Tosatti <mtosatti@redhat.com>
> Cc: Christian Borntraeger <borntraeger@de.ibm.com>
> Cc: Luiz Capitulino <lcapitulino@redhat.com>
> Cc: Paolo Bonzini <pbonzini@redhat.com>
> Signed-off-by: Frederic Weisbecker <fweisbec@gmail.com>

Acked-by: Rik van Riel <riel@redhat.com>


  reply	other threads:[~2015-03-05 16:32 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-03-05  2:14 [PATCH 0/7] nohz/rcu: Consider guest context as extended quiescent state (ie: enable full nohz on guest) Frederic Weisbecker
2015-03-05  2:14 ` [PATCH 1/7] ppc: Remove unused cpp symbols in kvm headers Frederic Weisbecker
2015-03-05 16:06   ` Rik van Riel
2015-03-05  2:14 ` [PATCH 2/7] context_tracking: Rename context symbols to prepare for transition state Frederic Weisbecker
2015-03-05 16:07   ` Rik van Riel [this message]
2015-03-05  2:14 ` [PATCH 3/7] context_tracking: Generalize context tracking APIs to support user and guest Frederic Weisbecker
2015-03-05  2:14 ` [PATCH 4/7] context_tracking: Add stub context_tracking_is_enabled Frederic Weisbecker
2015-03-05  2:14 ` [PATCH 5/7] context_tracking: Run vtime_user_enter/exit only when state == CONTEXT_USER Frederic Weisbecker
2015-03-05  2:14 ` [PATCH 6/7] context_tracking: Export context_tracking_user_enter/exit Frederic Weisbecker
2015-03-05  2:14 ` [PATCH 7/7] kvm,rcu,nohz: use RCU extended quiescent state when running KVM guest Frederic Weisbecker
2015-03-10 14:37 [GIT PULL] nohz: Enable full dynticks on guest mode Frederic Weisbecker
2015-03-10 14:37 ` [PATCH 2/7] context_tracking: Rename context symbols to prepare for transition state Frederic Weisbecker

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=54F87F34.80408@redhat.com \
    --to=riel@redhat.com \
    --cc=agraf@suse.de \
    --cc=benh@kernel.crashing.org \
    --cc=borntraeger@de.ibm.com \
    --cc=fweisbec@gmail.com \
    --cc=lcapitulino@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=luto@amacapital.net \
    --cc=mtosatti@redhat.com \
    --cc=paulmck@linux.vnet.ibm.com \
    --cc=pbonzini@redhat.com \
    --cc=will.deacon@arm.com \
    --subject='Re: [PATCH 2/7] context_tracking: Rename context symbols to prepare for transition state' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).