From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S932976AbbCEQcb (ORCPT <rfc822;w@1wt.eu>);
	Thu, 5 Mar 2015 11:32:31 -0500
Received: from mx1.redhat.com ([209.132.183.28]:57062 "EHLO mx1.redhat.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1751321AbbCEQca (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Thu, 5 Mar 2015 11:32:30 -0500
Message-ID: <54F87F34.80408@redhat.com>
Date: Thu, 05 Mar 2015 11:07:16 -0500
From: Rik van Riel <riel@redhat.com>
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.3.0
MIME-Version: 1.0
To: Frederic Weisbecker <fweisbec@gmail.com>,
        LKML <linux-kernel@vger.kernel.org>
CC: Paolo Bonzini <pbonzini@redhat.com>, Alexander Graf <agraf@suse.de>,
        Luiz Capitulino <lcapitulino@redhat.com>,
        Christian Borntraeger <borntraeger@de.ibm.com>,
        Benjamin Herrenschmidt <benh@kernel.crashing.org>,
        Marcelo Tosatti <mtosatti@redhat.com>,
        "Paul E . McKenney" <paulmck@linux.vnet.ibm.com>,
        Andy Lutomirski <luto@amacapital.net>,
        Will deacon <will.deacon@arm.com>
Subject: Re: [PATCH 2/7] context_tracking: Rename context symbols to prepare
 for transition state
References: <1425521696-4471-1-git-send-email-fweisbec@gmail.com> <1425521696-4471-3-git-send-email-fweisbec@gmail.com>
In-Reply-To: <1425521696-4471-3-git-send-email-fweisbec@gmail.com>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 03/04/2015 09:14 PM, Frederic Weisbecker wrote:
> Current context tracking symbols are designed to express living state.
> As such they are prefixed with "IN_": IN_USER, IN_KERNEL.
> 
> Now we are going to use these symbols to also express state transitions
> such as context_tracking_enter(IN_USER) or context_tracking_exit(IN_USER).
> But while the "IN_" prefix works well to express entering a context, it's
> confusing to depict a context exit: context_tracking_exit(IN_USER)
> could mean two things:
> 	1) We are exiting the current context to enter user context.
> 	2) We are exiting the user context
> We want 2) but the reviewer may be confused and understand 1)
> 
> So lets disambiguate these symbols and rename them to CONTEXT_USER and
> CONTEXT_KERNEL.
> 
> Cc: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
> Cc: Andy Lutomirski <luto@amacapital.net>
> Cc: Will deacon <will.deacon@arm.com>
> Cc: Marcelo Tosatti <mtosatti@redhat.com>
> Cc: Christian Borntraeger <borntraeger@de.ibm.com>
> Cc: Luiz Capitulino <lcapitulino@redhat.com>
> Cc: Paolo Bonzini <pbonzini@redhat.com>
> Signed-off-by: Frederic Weisbecker <fweisbec@gmail.com>

Acked-by: Rik van Riel <riel@redhat.com>