Re: [PATCH 0/3] selftests: ptrace, kcmp, efivars build failure fixes

[Shuah Khan <shuahkh@osg.samsung.com>]

On 03/10/2015 05:37 PM, Shuah Khan wrote:
> On 03/10/2015 05:35 PM, Michael Ellerman wrote:
>> On Tue, 2015-03-10 at 16:00 -0600, Shuah Khan wrote:
>>> ptrace, efivars, and kcmp Makefiles don't have explicit build rule.
>>> As a result, build fails when make is run from top level Makefile
>>> target kselftest. Without the explicit rule, make works only when
>>> it is run in the current directory or from selftests directory.
>>> Fxing the problems by adding an explicit build rule to fix the
>>> problem.
>>>
>>> Shuah Khan (3):
>>>   selftests: ptrace build fails when invoked from kselftest target
>>>   selftests: efivars build fails when invoked from kselftest target
>>>   selftests: kcmp build fails when invoked from kselftest target
>>>
>>>  tools/testing/selftests/efivarfs/Makefile | 2 ++
>>>  tools/testing/selftests/kcmp/Makefile     | 5 +++--
>>>  tools/testing/selftests/ptrace/Makefile   | 5 +++--
>>>  3 files changed, 8 insertions(+), 4 deletions(-)
>>
>> What? No. This is the bug my patch to filter the make flags fixes.
>>
>> cheers
>>
>>
> 
> Michael,
> 
> Did you see my email from yesterday on how your patch introduced
> more problems. Can you please make sure the patches you send work
> and don't introduce problems. I am having this issue with a lot
> of your patches.
> 

btw your patch doesn't fix the header file include problem. I don't
see any reason why individual Makefile shouldn't address this problem.

thanks,
-- Shuah

-- 
Shuah Khan
Sr. Linux Kernel Developer
Open Source Innovation Group
Samsung Research America (Silicon Valley)
shuahkh@osg.samsung.com | (970) 217-8978