From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752148AbbCJXkw (ORCPT ); Tue, 10 Mar 2015 19:40:52 -0400 Received: from lists.s-osg.org ([54.187.51.154]:54704 "EHLO lists.s-osg.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750772AbbCJXks (ORCPT ); Tue, 10 Mar 2015 19:40:48 -0400 Message-ID: <54FF80FE.1040708@osg.samsung.com> Date: Tue, 10 Mar 2015 17:40:46 -0600 From: Shuah Khan Organization: Samsung Open Source Group User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.5.0 MIME-Version: 1.0 To: Michael Ellerman CC: gorcunov@openvz.org, akpm@linux-foundation.org, tranmanphong@gmail.com, linux-kernel@vger.kernel.org, linux-api@vger.kernel.org Subject: Re: [PATCH 0/3] selftests: ptrace, kcmp, efivars build failure fixes References: <1426030513.20917.2.camel@ellerman.id.au> <54FF803E.9030407@osg.samsung.com> In-Reply-To: <54FF803E.9030407@osg.samsung.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 03/10/2015 05:37 PM, Shuah Khan wrote: > On 03/10/2015 05:35 PM, Michael Ellerman wrote: >> On Tue, 2015-03-10 at 16:00 -0600, Shuah Khan wrote: >>> ptrace, efivars, and kcmp Makefiles don't have explicit build rule. >>> As a result, build fails when make is run from top level Makefile >>> target kselftest. Without the explicit rule, make works only when >>> it is run in the current directory or from selftests directory. >>> Fxing the problems by adding an explicit build rule to fix the >>> problem. >>> >>> Shuah Khan (3): >>> selftests: ptrace build fails when invoked from kselftest target >>> selftests: efivars build fails when invoked from kselftest target >>> selftests: kcmp build fails when invoked from kselftest target >>> >>> tools/testing/selftests/efivarfs/Makefile | 2 ++ >>> tools/testing/selftests/kcmp/Makefile | 5 +++-- >>> tools/testing/selftests/ptrace/Makefile | 5 +++-- >>> 3 files changed, 8 insertions(+), 4 deletions(-) >> >> What? No. This is the bug my patch to filter the make flags fixes. >> >> cheers >> >> > > Michael, > > Did you see my email from yesterday on how your patch introduced > more problems. Can you please make sure the patches you send work > and don't introduce problems. I am having this issue with a lot > of your patches. > btw your patch doesn't fix the header file include problem. I don't see any reason why individual Makefile shouldn't address this problem. thanks, -- Shuah -- Shuah Khan Sr. Linux Kernel Developer Open Source Innovation Group Samsung Research America (Silicon Valley) shuahkh@osg.samsung.com | (970) 217-8978